Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload in dev only #240

Merged
merged 1 commit into from
May 13, 2016
Merged

Hot reload in dev only #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions build/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,18 @@ const APP_ENTRY = [
paths.docsSrc('DocsApp.js'),
]

webpackConfig.entry = {
app: __DEV__
? [webpackHotMiddlewareEntry, ...APP_ENTRY]
: [...APP_ENTRY],
webpackConfig.entry = __DEV__ ? {
app: [
webpackHotMiddlewareEntry,
...APP_ENTRY,
],
vendor: [
webpackHotMiddlewareEntry,
...config.compiler_vendor,
],
} : {
app: APP_ENTRY,
vendor: config.compiler_vendor,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see we were still putting HMR in the vendor bundle.

}

// ------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ deployment:
development:
branch: /^(?!master).*$/
commands:
- gulp docs
- NODE_ENV=production gulp docs
- $(npm bin)/ta-script aws/stage -d docs/build -r $CIRCLE_PROJECT_REPONAME -b $CIRCLE_BRANCH
production:
branch: master
commands:
- git config --global user.email "devteam+deweybot@technologyadvice.com"
- git config --global user.name "deweybot"
- $(npm bin)/ta-script circle_ci/create_changelog
- npm run deploy:docs
- NODE_ENV=production npm run deploy:docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI builds are node NODE_ENV production.