Remove babel-polyfill #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc4381f to
ee51ca3
Compare
| @@ -87,6 +87,7 @@ | |||
| "karma-mocha": "^0.2.2", | |||
| "karma-mocha-reporter": "^2.0.0", | |||
| "karma-phantomjs-launcher": "^1.0.0", | |||
| "karma-phantomjs-shim": "github:technologyadvice/karma-phantomjs-shim", | |||
There was a problem hiding this comment.
Can go back to main branch once String.repeat and String.includes are merged:
tschaub/karma-phantomjs-shim#6
tschaub/karma-phantomjs-shim#7
There was a problem hiding this comment.
karma-phantomjs-shim@1.4.0 published with both includes and repeat. Thanks for the contribution.
|
We could also use lodash repeat/includes, however, chai-enzyme also uses |
| ], | ||
| phantomjsLauncher: { | ||
| // exit on ResourceError, useful if karma exits without killing phantom | ||
| exitOnResourceError: true, |
There was a problem hiding this comment.
Interesting, didn't know about this.
There was a problem hiding this comment.
Me either, just saw it in the docs while debugging something else.
|
👻 |
|
(w/ tests passing) |
2157b04 to
163f376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #206, this PR removes the
babel-polyfillfor it's size and global namespace pollution. We don't want to drop this on our consumers.