List item prop renderers #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3343e5 to
ee05a32
Compare
| header && <div key='header' className='header'>{header}</div>, | ||
| _description && <div key='description' className='description'>{_description}</div>, | ||
| ] : ( | ||
| _description |
There was a problem hiding this comment.
Do not add description div if there is no header, it breaks middle aligned content.
ee05a32 to
945b2bd
Compare
Merged
| <div className='header'>{header}</div> | ||
| {description && <div className='description'>{description}</div>} | ||
| </div> | ||
| const media = iconPropRenderer(icon) || imagePropRenderer(image) |
|
Lgtm 🍂 |
|
Good to mine eyes 🌍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakout of #206, makes fixes to the list item component.
Prop renderers
Our
propRenderersutil gives us consistent intelligent handling of prop values. In this case,iconandimageprops. You can pass either a string or a component. See link above.In the case of a string value, a component will be created for you.
icon='user'would create an<Icon />with theuserclass.image='//placehold.itwould create an<Image />with thesrcattr set to the placehold.it url.