Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create common tests #217

Merged
merged 28 commits into from
Apr 2, 2016
Merged

Create common tests #217

merged 28 commits into from
Apr 2, 2016

Conversation

levithomason
Copy link
Member

This PR removes the conformance test and index.js test. These tests previously looped over the Stardust keys and did magic tests.

They have replaced and extended with a commonTests module that includes:

  • isConformant
  • hasUIClassName
  • hasSubComponents
  • rendersChildren
  • propNameOnlyToClassName
  • propValueOnlyToClassName
  • propNameAndValueToClassName
  • propNameOrValueToClassName

@levithomason levithomason force-pushed the feature/common-tests branch 2 times, most recently from 96f6ead to cac48a2 Compare April 1, 2016 20:28
levithomason
levithomason reviewed Apr 1, 2016
View reviewed changes
test/specs/Conformance-test.js
@@ -1,93 +0,0 @@
import _ from 'lodash'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conformance test is now an export of commonTests.

@levithomason levithomason force-pushed the feature/common-tests branch from cac48a2 to 0ddc198 Compare April 1, 2016 22:03
@levithomason
refactor(Conformance-test): split into commonTests
54bfa32
@levithomason
test(Confirm): conformance
4a16bf3
@levithomason
test(Textarea): conformance
2d3a179
@levithomason
test(Fields): conformance
8e1ca11
@levithomason
test(Form): conformance and renders children
b825d1b
@levithomason
test(Field): conformance and renders children
1cee20b
@levithomason
test(GridColumn): common tests
126cf79
@levithomason
test(GridRow): common tests
fd811eb
@levithomason
test(Grid): common tests
abcb647
@levithomason
test(Menu): add common
ed2952c
@levithomason
test(MenuItem): separate from Menu and add common
c7c629e
@levithomason
fix(MenuItem): cleanup and handle edge cases
15d3495
@levithomason
fix(Menu): cleanup and handle edge cases
79cd166
@levithomason
test(Message): add common
b18e05c
@levithomason
fix(TableColumn): make completely abstract
cd9bd40
@levithomason
test(Table): add common
3d019e6
@levithomason
test(Button): add common
d6d1d24
@levithomason
test(Icon): add common
42216c9
@levithomason
test(Input): add common
1e78ccb
@levithomason
refactor(Segments): use correct naming scheme
3d96a4f
@levithomason
test(Segments): add common
c425fcb
@levithomason
test(Checkbox): add common
bff1fac
@levithomason
test(Dropdown): add common
11159a6
@levithomason levithomason force-pushed the feature/common-tests branch from 0ddc198 to 09e9e73 Compare April 2, 2016 04:25
@levithomason levithomason merged commit ce9ad67 into master Apr 2, 2016
@levithomason levithomason deleted the feature/common-tests branch April 2, 2016 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@levithomason