Label component #215
Label component #215
Conversation
c20bb3e to
294c2ee
Compare
| @@ -37,7 +37,7 @@ export default class TryStardust extends Component { | |||
| - [x] Icon | |||
| - [x] Image | |||
| - [x] Input | |||
| - [ ] Label | |||
| - [x] Label | |||
There was a problem hiding this comment.
Mark it off in the support section of the README.
294c2ee to
904a256
Compare
| "release:major": "ta-script npm/release.sh major", | ||
| "release:minor": "ta-script npm/release.sh minor", | ||
| "release:patch": "ta-script npm/release.sh patch", | ||
| "start": "gulp", | ||
| "start": "npm run docs", |
There was a problem hiding this comment.
It seems it may be clearer to remove the docs script and call npm run gulp here. Is there a reason one may also want to run npm run docs separately?
There was a problem hiding this comment.
I think npm start should always start the project without a need to understand the underlying implementation. Also, if we drop gulp (which we hope to do), npm start should still start the project. If we tie the start script to gulp, then there is unnecessary coupling that would require updates to the README and dev workflow since they'll need to run a new command.
npm start might not always run the doc site, it will always "start the project". There is an npm run docs that will always run the doc site.
This is my rationale at least. Open to change if there is pretty good consensus that thinks otherwise.
| @@ -0,0 +1,40 @@ | |||
| import _ from 'lodash' | |||
| import { Children } from 'react' | |||
There was a problem hiding this comment.
Was curious as to the utilities associated with React.Children found documentation here and posting here for other's convenience.
|
🍶 |
|
LGTM 🐙 |
|
|
||
| /** Primary text of the label, same as children. */ | ||
| text: PropTypes.node, | ||
| } |
There was a problem hiding this comment.
Have you found a lot of benefit in making the label a pure function?
There was a problem hiding this comment.
Nope, it is actually more LOC and limits us from using life cycle methods. However, they will take advantage of extra optimization in future versions of React. So, we're getting on the bandwagon now.
|
Looks good: 🍂 |
904a256 to
1fbe7eb
Compare
Adds
<Label />component and tests. A separate PR will add docs.