Update build system #209
Merged
Update build system #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac514ac to
7a87bc5
Compare
| @@ -3,8 +3,5 @@ | |||
| "es2015", | |||
| "react", | |||
| "stage-1" | |||
| ], | |||
| "plugins": [ | |||
| "add-module-exports" | |||
There was a problem hiding this comment.
Removed this plugin in favor of using vanilla ES6 modules and require().default where necessary.
7a87bc5 to
e66c95d
Compare
| @@ -11,7 +11,7 @@ export default class ComponentExamples extends Component { | |||
| const examples = exampleContext.keys() | |||
| .filter(path => path.includes(`/${this.props.name}Examples.js`)) | |||
| .map((path, i) => { | |||
| const Example = exampleContext(path) | |||
| const Example = exampleContext(path).default | |||
There was a problem hiding this comment.
No more add-module-exports, so we need to use the default prop when require() is used. In this case, webpack require.context()
e66c95d to
61b0152
Compare
61b0152 to
280d97f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates necessary dependencies, improves dev experience, and removes as many build dependencies as possible.