Icon component #205
Merged
Icon component #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'icon', | ||
| ) | ||
| return ( | ||
| <i {...this.props} className={classes} /> |
There was a problem hiding this comment.
One thing I've seen with a lot of <Icon /> components is the usage of props for icon type rather than classes, that way it's not just a no-value-added wrapper over an <i> element. It also makes it quicker (read: less code) to create them (compare <Icon heart /> vs. <Icon className='heart' />)
Food for thought.
There was a problem hiding this comment.
Absolutely, we're going to move all Semantic UI class names into props once all components are done. Like so:
<Icon user />
<Grid centerAligned padded />|
Went to do this then pushed it back again. Wanted to get some perspective though. How would you add a on click callback then? Do we parse props and only turn boolean props into classes? Spreading the rest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178 includes docs. Replaces all
<i />with<Icon />and updates classes.