Support full dropdown functionality #168
Conversation
31628c0 to
9e7b716
Compare
633e1e6 to
cc91c86
Compare
| Fetch Items | ||
| </Button> | ||
| <Dropdown | ||
| className={`search selection multiple ${isFetching && 'disabled loading'}`} |
There was a problem hiding this comment.
I had opened an issue related to programmatic use of the loading indicator with https://github.com/TechnologyAdvice/stardust/issues/149. Can that be closed with this PR?
|
This is great! I left a couple of comments. Other than that the code looks great. Thanks for updating Examples given we have a new way to structure our menus now (e.g. Ship when ready: ⭐ |
8a37453 to
13b8c65
Compare
| export default class DropdownDropdownExample extends Component { | ||
| render() { | ||
| return ( | ||
| <Dropdown text='File' action='hide'> |
There was a problem hiding this comment.
If you only want to show a menu, and not have the text update, set the correct Semantic UI action. In this case, we just hide the dropdown on select. This leaves the File text in the dropdown space so it looks and works like a normal dropdown menu (not a selection dropdown).
81c15f6 to
e1e9c7f
Compare
e1e9c7f to
1b8a7df
Compare
…n-options Support full dropdown functionality
| return ( | ||
| <Dropdown className='disabled' text='Dropdown'> | ||
| <Dropdown.Menu> | ||
| <Dropdown.Item text='Choice 1' /> |
There was a problem hiding this comment.
I can't get this example to work. the Dropdown.Items don't show up.
Try It
There are 3 examples written. More will be added in other PRs later.
Not as large as it looks
This PR includes 3 primary things:
Done
Fixes #4 supporting all dropdown permutations. Also fixes #149 supporting dynamic options.