chore(Dropdown): add props for semantic settings #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +124,7 @@ export default class Dropdown extends Component { | |||
|
|
|||
| render() { | |||
| const options = _.map(this.props.options, (opt, i) => { | |||
| return <option key={i} value={opt.value}>{opt.text}</option>; | |||
| return <option key={opt.value} value={opt.value}>{opt.text}</option>; | |||
There was a problem hiding this comment.
Minor fix while I'm in here, index as key is a risky anti-pattern, and since the value is a string value we can just use that as the key.
There was a problem hiding this comment.
I swear React used to throw warnings in the console for this and then stopped. Not sure why they stopped.
There was a problem hiding this comment.
Only warns if key is missing, there is no way for React to know if it is an index or a real key.
|
🍂 |
|
🉑 |
| maxSelections: this.props.maxSelections, | ||
| on: this.props.on, | ||
| placeholder: this.props.placeholder, | ||
| saveRemoveData: this.props.saveRemoteData, |
There was a problem hiding this comment.
Looking at Dropdown Settings - Remote Settings this defaults to true, meaning form values persist to session storage. Though I haven't actually seen it function yet, it'd be nice to have in the future.
|
💫 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.