feat(datetime): Add component #1240

harel · 2017-01-27T19:26:10Z

This is a work in progress mainly focused on exploring the possiblity of adding a datetime component which supports date ranges, time and localisation.

TODO

Bugs and Features

Docs

document function prop signatures
change Week starts Sunday example to First Day Of Week show two examples, start on Sun, another on Monday.
fix disabled days example, do not import date utils

Cleanup

move component to /addons
remove cruft propTypes that do not exist
sort propTypes alphabetically
update Month.js to use DateTimeGrid, feat(datetime): Add component #1240 (comment)
complete all code TODOs in /Datetime
reverse onDateSelect args to match other callbacks, with event first.
remove unused methods in classes

levithomason

I realize this is work in progress. Couple typos that might trip you up:

levithomason · 2017-01-29T20:08:12Z

src/modules/Datetime/CalendarMonth.js

+  return <ElementType {...rest} className={classes}>{children}</ElementType>
+}
+
+DropdownMenu._meta = {


CalendarMonth._meta

levithomason · 2017-01-29T20:08:30Z

src/modules/Datetime/CalendarMonth.js

+  type: META.TYPES.MODULE,
+}
+
+DropdownMenu.propTypes = {


CalendarMonth.propTypes

harel · 2017-01-30T00:34:53Z

That component wasn't imported yet but fixed the typos. Did not solve the problem.

levithomason · 2017-01-30T00:46:30Z

Thanks for the note, I'll take a look at this branch later tonight and resolve the issue.

codecov-io · 2017-01-30T21:18:28Z

Codecov Report

Merging #1240 into master will decrease coverage by 80.65%.
The diff coverage is 39.78%.

@@             Coverage Diff             @@
##           master    #1240       +/-   ##
===========================================
- Coverage   99.73%   19.07%   -80.66%     
===========================================
  Files         151      159        +8     
  Lines        2624     2862      +238     
===========================================
- Hits         2617      546     -2071     
- Misses          7     2316     +2309

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	`0.51% <ø> (-99.49%)`	⬇️
src/addons/Datetime/DatetimeRange.js	`1.38% <1.38%> (ø)`
src/addons/Datetime/Datetime.js	`23.33% <23.33%> (ø)`
src/addons/Datetime/DatetimeMenu.js	`28.57% <28.57%> (ø)`
src/addons/Datetime/DatetimeHours.js	`30.76% <30.76%> (ø)`
src/addons/Datetime/DatetimeCalendar.js	`31.81% <31.81%> (ø)`
src/addons/Datetime/DatetimeMonths.js	`62.5% <62.5%> (ø)`
src/addons/Datetime/DatetimeGrid.js	`64.28% <64.28%> (ø)`
src/addons/Datetime/DatetimeYears.js	`76.92% <76.92%> (ø)`
src/addons/Datetime/DatetimeMinutes.js	`81.25% <81.25%> (ø)`
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470c7b5...f1a8e0d. Read the comment docs.

levithomason · 2017-01-30T21:19:02Z

Fixed:

-static PropTypes
+static propTypes

I also pushed a lot of cleanup so I could browse the code a little easier.

levithomason · 2017-03-03T16:36:16Z

Looks like we'll need to reabse this branch to master to get the commits in order. All the typings were moved from index.d.ts files to individual component files such as Button.d.ts. There is still an index.d.ts file but it just exports the default component file from the directory.

This is 1:1 with how the JS files are setup as well. LMK if you run into any issues with the rebase cleanup and I'll help out.

harel · 2017-03-06T01:50:00Z

No worries. I rebase periodically anyway so this will be just one more link in the chain. Didn't do much over the last few days because of life but i'm back at it this week.

levithomason · 2017-03-26T05:27:23Z

I've pushed some cleanup and a rebase to the latest master.

I think we should start breaking this PR down into small shipments and releasing it. This will allow us to focus on one chunk at a time and do a good job on just that. As we polish and release each piece, we can bring it back into this branch and prepare the next release.

Do you think we could somehow release Date only as the first component, the Time, and Datetime? I'm wondering if it makes sense to break these down that way API wise as it does release wise. Let me know your thoughts.

levithomason · 2017-03-26T05:51:01Z

Heads up, I'll be pushing some more refactors and cleanups for a bit here.

levithomason · 2017-03-26T07:54:04Z

OK, after pushing the latest I think we can ship Datetime with basic support first, then perhaps follow-up with the range support.

DateTimeGrid

I pushed a generic DateTimeGrid that is used in all but the Month view. It allows an easier construct the table cells, just pass a single array of as many cells as you want and tell the DateTimeGrid how many columns to fit them into. It will chunk out the Rows for you.

This will also give us the ability to handle different layouts, since the DateTimeGrid just takes a single array of cell props objects. We can use this array to build any layout. We can even, later on, expose a renderGrid prop and allow the user to render their own calendar grids if we wanted to.

TODO

I'd like to factor out the DayCell into the DateTimeGrid but am not 100% sure on how yet. I'd also like to move the dateUtils to the Datetime directory and perhaps remove more, if possible (I removed some already).

That's all I got for now, thanks for all the work on this and the patience dealing with my limited availability. We're getting close to something here 👍

KevinGorjan · 2017-04-24T09:09:59Z

Whats the status of this issue?

GregoryPotdevin · 2017-04-24T09:19:45Z

I'm also interested in this feature and can dedicate some time this week to test/code/document/brainstorm or whatever is needed.

harel · 2017-04-25T00:18:43Z

It's coming together, late stage development. There are a few things that require feedback - in particular the momentjs branch which decouples date handling to support both native js dates as well as moment/moment-timezone dates (or any other time framework).

…

On Mon, Apr 24, 2017 at 10:19 AM, Gregory Potdevin ***@***.*** > wrote: I'm also interested in this feature and can dedicate some time this week to test/code/document/brainstorm or whatever is needed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1240 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8Lena3iGagJIwWgDbL6GfmgN1rX2FXks5rzGkzgaJpZM4LwH1O> .

viiiprock · 2017-06-13T15:28:30Z

Hi guys, how is it going :)

revik · 2017-11-06T13:16:02Z

Can't wait, any progress ? Do you need help testing it?

dankirlin · 2017-11-06T15:06:55Z

Let me know if there is anyway I can help push this forward.

ydsood · 2017-11-06T18:41:25Z

Waiting eagerly for this to be completed. This is a very frequently used component in forms. Available for helping push this out soon.

neslinesli93 · 2017-11-07T00:18:26Z

Same here, count me in if you need anything

levithomason · 2017-11-25T16:10:47Z

If anyone would like to hop in here's some more info. Conformance tests are passing and there are plenty of doc site examples. What's needed is to run the doc site, try the examples, and fix the bugs. Bug fixes should also have tests written for them.

As soon as all the doc site examples are working with passing tests, this can be shipped. 🎉

srdjanRakic · 2017-12-13T13:17:20Z

How is it going guys ? Any news on this ?

Gallevy · 2017-12-20T21:44:00Z

Patiently waiting. Anything I can do to speed this up?

davidhenley · 2017-12-21T21:10:38Z

This is the final piece missing for all my forms using SUI. Can't wait!

hisuwh · 2017-12-22T08:57:09Z

All I want for Christmas is SUI datepicker 🎄 🎁 📆 😆

brianespinosa · 2017-12-22T15:29:43Z

Hey everyone! I think we are all excited to ship this. At the same time, there is only so much bandwidth that main contributors to this project have to give to open source work. The nice thing is that it's open source and we are happy to accept pull requests from anyone that moves this project/feature forward.

Per @levithomason's comment above, as soon as doc site examples are working and tests are passing for the reported bugs, this can be shipped. @Gallevy you asked if there is anything you can do to move this forward... we welcome any time you can dedicate to fixing any of the remaining bugs. Anyone else who has commented wanting to know what is going on, you are also welcome to help out. <3

srdjanRakic · 2017-12-25T09:41:32Z

@brianespinosa When will we be able to use this? :)

therealgilles · 2018-01-13T02:58:13Z

Could this PR be merged so that testing it is made easier? Thank you

levithomason · 2018-02-04T19:59:48Z

If you'd like to contribute to the development of this feature, please email me[at]levithomason.com. This thread produces too much noise and distracts from the focus.

levithomason · 2018-05-21T19:52:25Z

A few collaborators have emailed me and pushed this work forward. You are amazing ❤️.

I've ported this branch to our repo for easier management. I'm merging any well authored PRs against this effort.

See #2821 for the Datetime branch on the main repo
See #2813 as an example of how you can help in making PRs against the feature branch

levithomason reviewed Jan 29, 2017

View reviewed changes

levithomason added the needs engineering label Jan 30, 2017

levithomason removed the needs engineering label Jan 30, 2017

harel force-pushed the datetime branch from fc007a4 to 6ea8655 Compare March 13, 2017 00:02

layershifter changed the title ~~datetime(changelog): initial commit for datetime component experiments~~ feat(datetime): Add component Mar 21, 2017

layershifter added the ready for review label Mar 21, 2017

levithomason force-pushed the datetime branch 2 times, most recently from 4d54f2f to 87d50ed Compare March 26, 2017 05:12

levithomason removed the ready for review label Mar 26, 2017

levithomason mentioned this pull request Mar 28, 2017

Calendar/DateTimePicker Component #908

Open

levithomason force-pushed the datetime branch from 0282145 to a9056b7 Compare May 18, 2017 16:20

levithomason force-pushed the datetime branch 3 times, most recently from b1fec82 to 575dc34 Compare May 31, 2017 23:56

levithomason force-pushed the datetime branch 2 times, most recently from d39be38 to 2bb587a Compare August 21, 2017 22:19

levithomason force-pushed the datetime branch from d8a6977 to 641e968 Compare September 14, 2017 03:32

levithomason added 9 commits October 18, 2017 23:02

test(Datetime): fix most propType/typings tests

c1eb742

test(Datetime): fix all but onChange tests

86071ea

test(Datetime): pass conformance tests 🎉

26353ef

fix(gulp-react-docgen): handle null prop types

07f7601

fix(Datetime): fix layout styles

b8f75e8

fix(ComponentDoc): handle null prop types

4d45de1

fix(docs): run lint

929e260

fix(Datetime): cleanup styles and props

a7902d2

docs(Datetime): cleanup default props and styles

ebf33a6

levithomason force-pushed the datetime branch from 1be8dd8 to ebf33a6 Compare October 19, 2017 06:03

test(Datetime): fix utils and typings tests

f1a8e0d

levithomason mentioned this pull request Dec 12, 2017

Missing components #2267

Closed

Semantic-Org locked as spam and limited conversation to collaborators Feb 4, 2018

levithomason added 2 commits February 4, 2018 12:28

merge master, resolve conflicts

6bdd692

fix(Datetime): fix props so route renders

726aa2b

levithomason closed this May 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datetime): Add component #1240

feat(datetime): Add component #1240

harel commented Jan 27, 2017 •

edited

Loading

levithomason left a comment

levithomason Jan 29, 2017

levithomason Jan 29, 2017

harel commented Jan 30, 2017

levithomason commented Jan 30, 2017

codecov-io commented Jan 30, 2017 •

edited

Loading

levithomason commented Jan 30, 2017 •

edited

Loading

levithomason commented Mar 3, 2017

harel commented Mar 6, 2017

levithomason commented Mar 26, 2017

levithomason commented Mar 26, 2017

levithomason commented Mar 26, 2017

KevinGorjan commented Apr 24, 2017

GregoryPotdevin commented Apr 24, 2017

harel commented Apr 25, 2017 via email

viiiprock commented Jun 13, 2017

revik commented Nov 6, 2017

dankirlin commented Nov 6, 2017

ydsood commented Nov 6, 2017

neslinesli93 commented Nov 7, 2017

levithomason commented Nov 25, 2017

srdjanRakic commented Dec 13, 2017

Gallevy commented Dec 20, 2017

davidhenley commented Dec 21, 2017

hisuwh commented Dec 22, 2017

brianespinosa commented Dec 22, 2017

srdjanRakic commented Dec 25, 2017

therealgilles commented Jan 13, 2018

levithomason commented Feb 4, 2018

levithomason commented May 21, 2018

feat(datetime): Add component #1240

feat(datetime): Add component #1240

Conversation

harel commented Jan 27, 2017 • edited Loading

TODO

Bugs and Features

Docs

Cleanup

levithomason left a comment

Choose a reason for hiding this comment

levithomason Jan 29, 2017

Choose a reason for hiding this comment

levithomason Jan 29, 2017

Choose a reason for hiding this comment

harel commented Jan 30, 2017

levithomason commented Jan 30, 2017

codecov-io commented Jan 30, 2017 • edited Loading

Codecov Report

levithomason commented Jan 30, 2017 • edited Loading

levithomason commented Mar 3, 2017

harel commented Mar 6, 2017

levithomason commented Mar 26, 2017

levithomason commented Mar 26, 2017

levithomason commented Mar 26, 2017

DateTimeGrid

TODO

KevinGorjan commented Apr 24, 2017

GregoryPotdevin commented Apr 24, 2017

harel commented Apr 25, 2017 via email

viiiprock commented Jun 13, 2017

revik commented Nov 6, 2017

dankirlin commented Nov 6, 2017

ydsood commented Nov 6, 2017

neslinesli93 commented Nov 7, 2017

levithomason commented Nov 25, 2017

srdjanRakic commented Dec 13, 2017

Gallevy commented Dec 20, 2017

davidhenley commented Dec 21, 2017

hisuwh commented Dec 22, 2017

brianespinosa commented Dec 22, 2017

srdjanRakic commented Dec 25, 2017

therealgilles commented Jan 13, 2018

levithomason commented Feb 4, 2018

levithomason commented May 21, 2018

harel commented Jan 27, 2017 •

edited

Loading

codecov-io commented Jan 30, 2017 •

edited

Loading

levithomason commented Jan 30, 2017 •

edited

Loading