-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextArea): add autoHeight
prop
#1083
feat(TextArea): add autoHeight
prop
#1083
Conversation
Current coverage is 95.84% (diff: 100%)@@ master #1083 diff @@
==========================================
Files 873 874 +1
Lines 4827 4835 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4626 4634 +8
Misses 201 201
Partials 0 0
|
I have no idea how to write tests checking if height of the textarea element changed. Any clues? |
Thanks for getting this going. I've refactored it a bit, adding docs and tests. LMK if anything looks out of place. I'll get a final review on this and merge once tests pass and you sign off on my updates. |
Also, can you please update the PR description so it closes the issue when merged? Docs here. |
Looks great, thanks. |
Cool, thanks. There seems to be a 1px rendering difference on CI than locally. I'll try to fix this. The comment will need to be in the main description of the PR to close the issue 👍 |
autoHeight
prop
Released in |
Fixes #982
Tested on Chrome and Firefox. I'll provide test cases in further commit in the nearest future