docs(StatisticGroup): add color, size, and inverted examples #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.82% (diff: 100%)
|
levithomason
requested changes
Dec 20, 2016
| const StatisticExampleGroupColored = () => ( | ||
| <div> | ||
| <Statistic.Group items={items} color='blue' /> | ||
| </div> |
There was a problem hiding this comment.
Since there is only one element here, let's forgo the extra div wrapper and just return the <Statistic.Group /> itself.
| ] | ||
|
|
||
| const StatisticExampleGroupInverted = () => ( | ||
| <div> |
There was a problem hiding this comment.
Same here, let's drop the extra div.
|
@levithomason removed the extra divs from the components. |
levithomason
approved these changes
Dec 20, 2016
|
Perfect! |
|
Thanks so much @levithomason I'll start looking at some more issues! |
|
Awesome, we try to keep good labeling practices. I'd suggest looking at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for Statistic Group examples for
color,size, andinvertedprops.