-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/divider component #103
Conversation
</div> | ||
); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does SD have a <Column>
component? I used regular <div>
and set the className to column in this example. We do need the columns though to get the proper formatting to show the vertical dividers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, comments on this above before seeing your comment. Yep, just add Grid, Column
to the import from stardust. Like other components, they include all the necessary base classes so you only need to add modifier classes (like three column relaxed
to the <Grid />
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that, both Column
and Grid
work 👍
e6f777f
to
874bcc5
Compare
import DividerTypesExamples from './Types/DividerTypesExamples'; | ||
import DividerVariationsExamples from './Variations/DividerVariationsExamples'; | ||
|
||
export default class ButtonExamples extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class name >.<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, it never stops
After updating the one class name and using |
Add a
<Divider />
component and examples for the divider. (Note: currently failing the Wercker test as a result of the Babel update)