test(Accordion): add inclusive tests for opening and closing panels #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)
@@ feat/accordion-exclusive #1023 diff @@
=======================================================
Files 137 137
Lines 2287 2287
Methods 0 0
Messages 0 0
Branches 0 0
=======================================================
+ Hits 2286 2287 +1
+ Misses 1 0 -1
Partials 0 0
|
|
Awesome, thank you! |
levithomason
added a commit
that referenced
this pull request
Dec 16, 2016
* Add ability for activeIndex in Accordions to be an array Allowing multiple open panels at once, need help with transforming activeIndex prop to an array. * feat(Accordion): ability to open multiple items * docs(Accordion): add missing period * fix(Accordion): remove redundant defaultActiveIndex logic * refactor(Accordion): consolidate active index checks * test(Accordion): fix exclusive test, use array defaultActiveIndex * test(Accordion): silence console for known prop type warning * docs(ExampleSection): add whitespace to bottom of page * test(Accordion): add inclusive tests for opening and closing panels (#1023) test(Accordion): add inclusive tests for opening and closing panels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the final tests for the issue 988.