-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure #1
Structure #1
Conversation
Nice, this looks good so far. I removed most of my comments after reviewing our react style guide in more detail. Only survivor: The directory I think we'd benefit by dropping in a component that requires more moving parts. This way we can have that structure nailed when starting real components. Thoughts? |
Yeah, I was thinking for the file structure something like the following:
I honestly don't think stardust components will need anything too crazy, like a flux cycle. They should receive their state from props mostly. |
Gotcha. OK, let's roll with what you outlined there then, dropping the redundant name. Once we get to building components we can iterate. ITERATE! :D Edit ...emoji pending |
|
Hey, so this is a proposal for how the file structure should be. Essentially we would have the App.js render all of the components on a sample page, and all of the components live within their own folder within the components directory.
Feedback is required ;)