feat: auth screens #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
typeWolffo
commented
Jul 16, 2024
•
k1eu
reviewed
Jul 18, 2024
Comment on lines
19
to
23
| app.enableCors({ | ||
| origin: "https://app.guidebook.localhost", | ||
| credentials: true, | ||
| }); | ||
|
|
There was a problem hiding this comment.
origin should come from envs so it's usable when deployed
| "morgan": "^1.10.0", | ||
| "next-themes": "^0.3.0", |
Comment on lines
28
to
33
| <Sheet open={isSheetOpen} onOpenChange={setIsSheetOpen}> | ||
| <SheetContent side="left"> | ||
| <SheetHeader> | ||
| <SheetDescription> | ||
| <div className="flex flex-col gap-2 px-2"> | ||
| <div> |
There was a problem hiding this comment.
I think the Sheet itself can be a seprate compoent
Comment on lines
30
to
32
| document.documentElement.classList.toggle("dark"); | ||
| localStorage.setItem( | ||
| "theme", |
There was a problem hiding this comment.
you can add a listerner somewhere on top so it also renders correct mode after refresh
There was a problem hiding this comment.
@k1eu so I made the theme toggle completely new using the zustand store. What do you think?
(useTheme from shadcn doesn't seem to support SPA mode in the remix)
3e51888 to
9531003
Compare
k1eu
requested changes
Jul 19, 2024
k1eu
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.