feat: fe test setup #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da14d7c to
7cb3f21
Compare
ea99620 to
a3bf360
Compare
k1eu
requested changes
Aug 2, 2024
Comment on lines
12
to
25
| vi.mock("../../../api/api-client"); | ||
| vi.mock("@remix-run/react", async () => { | ||
| const module = | ||
| await vi.importActual<typeof import("@remix-run/react")>( | ||
| "@remix-run/react" | ||
| ); | ||
| return { | ||
| ...module, | ||
| useNavigate: () => mockedUseNavigate, | ||
| Link: ({ to, children }: PropsWithChildren<{ to: string }>) => ( | ||
| <a href={to}>{children}</a> | ||
| ), | ||
| }; | ||
| }); |
There was a problem hiding this comment.
can we move it to some method that we just fire in all the tests?
Comment on lines
47
to
49
| ApiClient.auth.authControllerLogin.mockResolvedValue({ | ||
| data: "", | ||
| }); |
There was a problem hiding this comment.
we can have mock service worker running with the tests which would act as better mock solution
There was a problem hiding this comment.
i think i'd keep the seed near the top of the api like in src folder - also we can explore if we want to break it down into smaller pieces like seedAdmin(), seedUsers(), seedFiles() wdyt @mikoscz ?
| document.documentElement.classList.remove("dark"); | ||
| }) | ||
| .exhaustive(); | ||
| if (typeof document !== "undefined") { |
| "lint": "eslint --ignore-path .gitignore --cache --cache-location ./node_modules/.cache/eslint .", | ||
| "start": "cross-env NODE_ENV=production node ./server.js", | ||
| "generate:client": "swagger-typescript-api -p ../api/src/swagger/api-schema.json -o ./app/api --axios --name generated-api.ts --api-class-name API", | ||
| "typecheck": "tsc" | ||
| "typecheck": "tsc", |
There was a problem hiding this comment.
Suggested change
| "typecheck": "tsc", | |
| "tsc": "tsc --noEmit", |
There was a problem hiding this comment.
also you can add tsc-lint : tsc --noEmit && eslint command
There was a problem hiding this comment.
I'd keep the tests next to components - without tests folder
a35c4be to
fb064f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.