Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify user description issue template #15165

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Jan 26, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Documentation


Description

  • Simplified the pull request template for contributors.

  • Removed redundant sections to streamline the process.


Changes walkthrough 📝

Relevant files
Documentation
PULL_REQUEST_TEMPLATE.md
Simplified the pull request template structure                     

.github/PULL_REQUEST_TEMPLATE.md

  • Removed the Description section from the template.
  • Retained the Motivation and Context section for clarity.
  • Simplified the template to focus on essential details.
  • +0/-4     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member Author

    Each time when I create PR, the description is duplicated:
    image

    So may be just remove extra description section from template?

    @diemol diemol merged commit f4e234d into SeleniumHQ:trunk Jan 27, 2025
    4 checks passed
    @nvborisenko nvborisenko deleted the pr-template branch January 27, 2025 10:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants