-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Address some build warnings #15157
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see less warnings ✅
PR Type
Bug fix, Enhancement
Description
Removed redundant exception message in
Cookie.FromDictionary
.Added null-forgiving operator to avoid nullable warnings in
CookieJar
.Updated obsolete
CodeBase
handling inFileUtilities
with conditional checks.Changes walkthrough 📝
Cookie.cs
Simplified exception handling in `Cookie.FromDictionary`
dotnet/src/webdriver/Cookie.cs
ArgumentNullException
.CookieJar.cs
Improved nullability handling in `CookieJar`
dotnet/src/webdriver/CookieJar.cs
FileUtilities.cs
Updated obsolete `CodeBase` handling in `FileUtilities`
dotnet/src/webdriver/Internal/FileUtilities.cs
CodeBase
property.