Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] support Selenium Manager using proxy info from options #12036

Merged
merged 2 commits into from
May 15, 2023

Conversation

titusfortner
Copy link
Member

This is for Java solution to #11294

I tested it and made sure it worked locally.

My primary question is how to handle http vs ssl. Does this logic look correct?

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a6b075) 54.85% compared to head (50425f0) 54.85%.

❗ Current head 50425f0 differs from pull request most recent head a89f759. Consider uploading reports for the commit a89f759 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #12036   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files          86       86           
  Lines        5728     5728           
  Branches      233      233           
=======================================
  Hits         3142     3142           
  Misses       2353     2353           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bonigarcia bonigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants