Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Add enum for _PageLoadStrategyDescriptor #13236

Closed
M1troll opened this issue Dec 4, 2023 · 5 comments · Fixed by #13258
Closed

[🚀 Feature]: Add enum for _PageLoadStrategyDescriptor #13236

M1troll opened this issue Dec 4, 2023 · 5 comments · Fixed by #13258
Labels
C-py help wanted Issues looking for contributions I-enhancement

Comments

@M1troll
Copy link
Contributor

M1troll commented Dec 4, 2023

Feature and motivation

Hi!

In my project, I've encountered a situation where I need to change the default page load strategy, but the only way to find the names of the available strategies is by searching the documentation or looking at the descriptor implementation.

I think it would be convenient to have an enum for these names. This would help with hints of available strategy names and save us from having to remember their full names. It would also be great to add info about difference between these strategies in the docstring of this class, as is done in the documentation.

Thanks!

Usage example

If enum is named PageLoadStrategy, I can easily use strategy name as follows:

from selenium import webdriver
from selenium.webdriver.chrome.options import Options, PageLoadStrategy

options = Options()
options.page_load_strategy = PageLoadStrategy.EAGER
Copy link

github-actions bot commented Dec 4, 2023

@M1troll, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Dec 4, 2023

Would you like to send a PR for this?

@diemol diemol added C-py and removed needs-triaging labels Dec 4, 2023
@titusfortner titusfortner added the help wanted Issues looking for contributions label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@M1troll
Copy link
Contributor Author

M1troll commented Dec 5, 2023

Would you like to send a PR for this?

Yes, I can

M1troll added a commit to M1troll/selenium that referenced this issue Dec 7, 2023
M1troll added a commit to M1troll/selenium that referenced this issue Dec 7, 2023
M1troll added a commit to M1troll/selenium that referenced this issue Dec 7, 2023
M1troll added a commit to M1troll/selenium that referenced this issue Dec 7, 2023
diemol pushed a commit that referenced this issue Dec 8, 2023
Copy link

github-actions bot commented Jan 8, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-py help wanted Issues looking for contributions I-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants