Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Helm scripts into 3 - core, analytics and kafka #75

Merged
merged 4 commits into from
Jan 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm-charts/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CHARTS=seldon-core seldon-core-loadtesting
CHARTS=seldon-core seldon-core-analytics seldon-core-kafka seldon-core-loadtesting


build_all:
Expand Down
12 changes: 12 additions & 0 deletions helm-charts/seldon-core-analytics/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: v1
description: Seldon Core Analytics
keywords:
- seldon-core
- kubernetes
- machine-learning
- prometheus
- grafana
name: seldon-core-analytics
sources:
- https://github.com/SeldonIO/seldon-core
version: 0.1
2 changes: 2 additions & 0 deletions helm-charts/seldon-core-analytics/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
NOTES: TODO

7 changes: 7 additions & 0 deletions helm-charts/seldon-core-analytics/values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
alertmanager:
config:
enabled: false
grafana_prom_service_type: NodePort
grafana_prom_admin_password: admin
persistence:
enabled: true
9 changes: 9 additions & 0 deletions helm-charts/seldon-core-kafka/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: v1
description: Seldon Core Kafka
keywords:
- seldon-core
- kafka
name: seldon-core-kafka
sources:
- https://github.com/SeldonIO/seldon-core
version: 0.1
2 changes: 2 additions & 0 deletions helm-charts/seldon-core-kafka/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
NOTES: TODO

6 changes: 6 additions & 0 deletions helm-charts/seldon-core-kafka/values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kafka_core:
image:
tag: '0.1'
zookeeper:
image:
tag: '1.0'
190 changes: 0 additions & 190 deletions helm-charts/seldon-core/templates/kube-apiserver.yaml

This file was deleted.

14 changes: 0 additions & 14 deletions helm-charts/seldon-core/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
alertmanager:
config:
enabled: false
apife:
image:
pull_policy: IfNotPresent
Expand All @@ -17,17 +14,6 @@ cluster_manager:
engine:
image:
tag: 0.1.3-SNAPSHOT
grafana_prom_service_type: NodePort
kafka_core:
image:
tag: '0.1'
kube_apiserver:
enabled: false
persistence:
enabled: true
redis:
image:
tag: 4.0.1
zookeeper:
image:
tag: '1.0'
20 changes: 0 additions & 20 deletions helm-charts/seldon-core/values.yaml.example
Original file line number Diff line number Diff line change
Expand Up @@ -29,28 +29,8 @@ zookeeper:
redis:
image:
tag: "4.0.1"
kube_apiserver:
enabled: false


alertmanager:
# config disabled by default, create file "/files/alertmanager/config.yaml" then enable
config:
enabled: false


# set the grafana admin password
#grafana_prom_admin_password:

# Set the type of service for Grafana Prom
#grafana_prom_service_type: LoadBalancer
grafana_prom_service_type: NodePort

# Set the type of service for apife
#apife_service_type: LoadBalancer
apife_service_type: NodePort

# Persist data to a persitent volume
persistence:
enabled: true

6 changes: 2 additions & 4 deletions notebooks/advanced_graphs.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@
"source": [
"!helm install ../helm-charts/seldon-core --name seldon-core \\\n",
" --set cluster_manager.rbac=true \\\n",
" --set cluster_manager_client_secret=secret \\\n",
" --set cluster_manager_service_type=LoadBalancer \\\n",
" --set grafana_prom_service_type=LoadBalancer \\\n",
" --set apife_service_type=LoadBalancer"
]
},
Expand Down Expand Up @@ -767,7 +765,7 @@
"metadata": {
"anaconda-cloud": {},
"kernelspec": {
"display_name": "Python [default]",
"display_name": "Python 2",
"language": "python",
"name": "python2"
},
Expand All @@ -781,7 +779,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython2",
"version": "2.7.12"
"version": "2.7.11"
}
},
"nbformat": 4,
Expand Down
9 changes: 7 additions & 2 deletions notebooks/kubectl_demo_gcp.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@
"source": [
"!helm install ../helm-charts/seldon-core --name seldon-core \\\n",
" --set cluster_manager.rbac=true \\\n",
" --set cluster_manager_client_secret=secret \\\n",
" --set cluster_manager_service_type=LoadBalancer \\\n",
" --set grafana_prom_service_type=LoadBalancer \\\n",
" --set apife_service_type=LoadBalancer"
]
},
Expand All @@ -82,6 +80,13 @@
"!python -m grpc.tools.protoc -I./proto --python_out=./proto --grpc_python_out=./proto ./proto/prediction.proto"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"Setup pyhton code to do RESR and gRPC requests. **Only run this when the LoadBalancer created by GCP for the seldon-apife is running**"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down
Loading