Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Evaluation of Reverting "Jenkins X add comment when pipeline finishes" to remove test flakiness #2174

Closed
wants to merge 28 commits into from

Conversation

axsaucedo
Copy link
Contributor

Reverts #2149

This PR aims to evaluate whether flakiness was introduced due to this PR

axsaucedo added 28 commits July 20, 2020 20:25
This reverts commit 520fc8c.
This reverts commit ecf517e.
This reverts commit 320cbd7.
This reverts commit 34727ac.
This reverts commit ab3bc2f.
This reverts commit f57b7fe.
This reverts commit 9dd5dc4.
This reverts commit 9796968.
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jul 20 19:27:23 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=1

@seldondev
Copy link
Collaborator

Mon Jul 20 19:27:37 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=2

@axsaucedo
Copy link
Contributor Author

/test integration
/test notebooks
/test this

@seldondev
Copy link
Collaborator

Mon Jul 20 20:09:51 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=3

@seldondev
Copy link
Collaborator

Mon Jul 20 20:09:53 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=5

@seldondev
Copy link
Collaborator

Mon Jul 20 20:09:55 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=4

@axsaucedo
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jul 21 05:44:24 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2174/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2174 --build=6

@axsaucedo
Copy link
Contributor Author

Closing as it seems it's not the docker image dependencies that is causing the issue

@axsaucedo axsaucedo closed this Jul 21, 2020
@RafalSkolasinski RafalSkolasinski deleted the revert-2149-2148_jenkins_x_pipelines branch February 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants