Allow seldon inspect to output raw or json (#432)

* Allow seldon inspect to output raw or json

* review fixes

* Review fixes

* update docs

docs/source/contents/cli/docs/seldon.md

@@ -17,4 +17,4 @@
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 * [seldon server](seldon_server.md)	 - manage servers
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_experiment.md

@@ -31,4 +31,4 @@ seldon experiment <subcomand> [flags]
 * [seldon experiment status](seldon_experiment_status.md)	 - get status for experiment
 * [seldon experiment stop](seldon_experiment_stop.md)	 - stop an experiment
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_experiment_list.md

@@ -28,4 +28,4 @@ seldon experiment list [flags]
 
 * [seldon experiment](seldon_experiment.md)	 - manage experiments
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_experiment_start.md

@@ -29,4 +29,4 @@ seldon experiment start [flags]
 
 * [seldon experiment](seldon_experiment.md)	 - manage experiments
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_experiment_status.md

@@ -29,4 +29,4 @@ seldon experiment status <experimentName> [flags]
 
 * [seldon experiment](seldon_experiment.md)	 - manage experiments
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_experiment_stop.md

@@ -28,4 +28,4 @@ seldon experiment stop <experimentName> [flags]
 
 * [seldon experiment](seldon_experiment.md)	 - manage experiments
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model.md

@@ -33,4 +33,4 @@ seldon model <subcomand> [flags]
 * [seldon model status](seldon_model_status.md)	 - get status for model
 * [seldon model unload](seldon_model_unload.md)	 - unload a model
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_infer.md

@@ -34,4 +34,4 @@ seldon model infer <modelName> (data) [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_list.md

@@ -28,4 +28,4 @@ seldon model list [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_load.md

@@ -29,4 +29,4 @@ seldon model load [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_metadata.md

@@ -28,4 +28,4 @@ seldon model metadata <modelName> [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_status.md

@@ -29,4 +29,4 @@ seldon model status <modelName> [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_model_unload.md

@@ -28,4 +28,4 @@ seldon model unload <modelName> [flags]
 
 * [seldon model](seldon_model.md)	 - manage models
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline.md

@@ -33,4 +33,4 @@ seldon pipeline <subcomand> [flags]
 * [seldon pipeline status](seldon_pipeline_status.md)	 - status of a pipeline
 * [seldon pipeline unload](seldon_pipeline_unload.md)	 - unload a pipeline
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_infer.md

@@ -34,4 +34,4 @@ seldon pipeline infer <pipelineName> (data) [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_inspect.md

@@ -13,11 +13,13 @@ seldon pipeline inspect <expression> [flags]
 ### Options
 
 ```
+      --format string           inspect output format: raw or json. Default raw (default "raw")
   -h, --help                    help for inspect
       --kafka-broker string     kafka broker (default "0.0.0.0:9092")
       --offset int              message offset to start reading from, i.e. default 1 is the last message only (default 1)
       --request-id string       request id to show, if not specified will be all messages in offset range
       --scheduler-host string   seldon scheduler host (default "0.0.0.0:9004")
+      --verbose                 verbose output
 ```
 
 ### Options inherited from parent commands
@@ -31,4 +33,4 @@ seldon pipeline inspect <expression> [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_list.md

@@ -28,4 +28,4 @@ seldon pipeline list [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_load.md

@@ -29,4 +29,4 @@ seldon pipeline load [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_status.md

@@ -29,4 +29,4 @@ seldon pipeline status <pipelineName> [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_pipeline_unload.md

@@ -28,4 +28,4 @@ seldon pipeline unload <pipelineName> [flags]
 
 * [seldon pipeline](seldon_pipeline.md)	 - manage pipelines
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_server.md

@@ -29,4 +29,4 @@ seldon server <subcomand> [flags]
 * [seldon server list](seldon_server_list.md)	 - get list of servers
 * [seldon server status](seldon_server_status.md)	 - get status for server
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_server_list.md

@@ -28,4 +28,4 @@ seldon server list [flags]
 
 * [seldon server](seldon_server.md)	 - manage servers
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

docs/source/contents/cli/docs/seldon_server_status.md

@@ -29,4 +29,4 @@ seldon server status [flags]
 
 * [seldon server](seldon_server.md)	 - manage servers
 
-###### Auto generated by spf13/cobra on 13-Aug-2022
+###### Auto generated by spf13/cobra on 8-Sep-2022

operator/cmd/seldon/cli/pipeline_inspect.go

@@ -1,15 +1,19 @@
 package cli
 
 import (
+	"fmt"
+
 	"k8s.io/utils/env"
 
 	"github.com/seldonio/seldon-core/operatorv2/pkg/cli"
 	"github.com/spf13/cobra"
 )
 
 const (
-	OffsetFlag    = "offset"
-	RequestIdFlag = "request-id"
+	offsetFlag       = "offset"
+	requestIdFlag    = "request-id"
+	outputFormatFlag = "format"
+	verboseFlag      = "verbose"
 )
 
 func createPipelineInspect() *cobra.Command {
@@ -27,11 +31,19 @@ func createPipelineInspect() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			offset, err := cmd.Flags().GetInt64(OffsetFlag)
+			offset, err := cmd.Flags().GetInt64(offsetFlag)
+			if err != nil {
+				return err
+			}
+			requestId, err := cmd.Flags().GetString(requestIdFlag)
+			if err != nil {
+				return err
+			}
+			format, err := cmd.Flags().GetString(outputFormatFlag)
 			if err != nil {
 				return err
 			}
-			requestId, err := cmd.Flags().GetString(RequestIdFlag)
+			verbose, err := cmd.Flags().GetBool(verboseFlag)
 			if err != nil {
 				return err
 			}
@@ -40,13 +52,15 @@ func createPipelineInspect() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			err = kc.InspectStep(string(data), offset, requestId)
+			err = kc.InspectStep(string(data), offset, requestId, format, verbose)
 			return err
 		},
 	}
 	cmdPipelineInspect.Flags().String(kafkaBrokerFlag, env.GetString(EnvKafka, DefaultKafkaHost), "kafka broker")
-	cmdPipelineInspect.Flags().Int64(OffsetFlag, 1, "message offset to start reading from, i.e. default 1 is the last message only")
-	cmdPipelineInspect.Flags().String(RequestIdFlag, "", "request id to show, if not specified will be all messages in offset range")
+	cmdPipelineInspect.Flags().Int64(offsetFlag, 1, "message offset to start reading from, i.e. default 1 is the last message only")
+	cmdPipelineInspect.Flags().String(requestIdFlag, "", "request id to show, if not specified will be all messages in offset range")
 	cmdPipelineInspect.Flags().String(schedulerHostFlag, env.GetString(EnvScheduler, DefaultScheduleHost), "seldon scheduler host")
+	cmdPipelineInspect.Flags().String(outputFormatFlag, cli.InspectFormatRaw, fmt.Sprintf("inspect output format: raw or json. Default %s", cli.InspectFormatRaw))
+	cmdPipelineInspect.Flags().Bool(verboseFlag, false, "verbose output")
 	return cmdPipelineInspect
 }

operator/pkg/cli/constants.go

@@ -0,0 +1,7 @@
+package cli
+
+// CLI constants
+const (
+	InspectFormatRaw  = "raw"
+	InspectFormatJson = "json"
+)