Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaside-Squeak-Core String>>#trimBlanks method inhibits porting #64

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 9 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?

1. Inspect:  (Character cr asString, '    abc') trimBlanks 

What is the expected output? What do you see instead?

On Squeak and Dolphin, I see 'abc'; on VW and VA Smalltalk I see '
   abc' (a CR, three spaces, and 3 letters).

What version of the product are you using? On what operating system?

Seaside-Core pmm.141
Seaside-Squeak-Core lr.44
Seaside-Test pmm.112 

Running on WinXP

Please provide any additional information below.

Since the #trimBlanks method actually removes all separators, it seems 
badly named at best.

Both VW and VA Smalltalk implement String>>#trimBlanks to remove only 
spaces, not all separators.  Dolphin's #trimBlanks implementation matches 
Seaside-Squeak-Core; I don't know about GST or Gemstone.

VA Smalltalk has a similar method, #trimSeparators, to remove all 
separators; I have not found a similar method in other implementations.

I suggest changing the Seaside-Squeak-Core String>>#trimBlanks method (and 
references to it) to String>>#trimSeparators to more-correctly describe 
its function as well as aiding porting.

Original issue reported on code.google.com by wembley....@gmail.com on 6 May 2008 at 4:06

dalehenrich added a commit to dalehenrich/Seaside that referenced this issue Sep 7, 2015
… when logging a commit conflict to the object log, we'll just pass the url of the native request ... unless the GsSocket is sneaking into a persistent root some other (less obvious way) ... logging commit conflicts should now be safe and hopefully the FastCGI-related GsSocket "lost state" errors nuked
dalehenrich pushed a commit to dalehenrich/Seaside that referenced this issue Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant