Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQDraggableFunctionalTest >> renderContentOn: assumes Symbol equals String #1260

Closed
marianopeck opened this issue Jul 19, 2021 · 0 comments
Closed

Comments

@marianopeck
Copy link
Contributor

As we all know, the equality between Symbol and String is one of the big difference between Smalltalk dialects. In Pharo it is true while in other dialects like GemStone or VAST, it is false. Therefore, I propose to change the line

callbackDraggable: [ :e | top := (e at: #position) at:#top. left := (e at: #position) at:#left ];

to:

callbackDraggable: [ :e | top := (e at: #position) at: 'top'. left := (e at: #position) at: 'left' ];

As the keys are originally as String, that would work in all dialects.

marianopeck added a commit to instantiations/Seaside that referenced this issue Jul 19, 2021
jbrichau pushed a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants