Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Prototype-Tests-Core' should also require 'Seaside-Test-Cavas' #1255

Closed
marianopeck opened this issue Jul 7, 2021 · 0 comments
Closed

'Prototype-Tests-Core' should also require 'Seaside-Test-Cavas' #1255

marianopeck opened this issue Jul 7, 2021 · 0 comments

Comments

@marianopeck
Copy link
Contributor

In #baselinescriptaculous: we can see this:

package: 'Prototype-Tests-Core' with: [
				spec requires: #('Prototype-Core' 'Javascript-Tests-Core' 'Seaside-Tests-Functional') ];

However, Prototype-Tests-Core has subclass of WAScriptGeneratorTest. WAScriptGeneratorTest belongs to Seaside-Test-Cavas and this package is not included in the above #requires.

Proposed change:

package: 'Prototype-Tests-Core' with: [
				spec requires: #('Prototype-Core' 'Javascript-Tests-Core' 'Seaside-Tests-Functional' 'Seaside-Test-Cavas' ) ];
marianopeck added a commit to instantiations/Seaside that referenced this issue Jul 19, 2021
jbrichau pushed a commit that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants