Massrole module #56
Merged
Massrole module #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15bd079.
Fixed remove-all
Removed config.json
Fixed SCDerox request and added anoter TODO
|
sorry, your pull request removes dependencies that are needed in a production enviroment. Please undo these changes and fix the conflicted file |
I think this happened when we tried breaking it to get it to work on windows. ~~I hope it doesn't destroy my module~~
Fixed ESLint syntax errors
Removed semicolon
|
Hereby I request another review over this module. It should work now I guess |
SCDerox
requested changes
May 1, 2022
SCDerox
requested changes
May 1, 2022
SCDerox
requested changes
May 1, 2022
Co-authored-by: Simon <sc.de@gmx.de>
SCDerox
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I created a now module, which I think is finished now, so I would like to see it being usable in your service soon. (Only if there are no problems with it of course. Feel free to suggest corrections if you find any)