Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(decompress): Exclude '*.nsis' that may cause error #5294

Merged
merged 3 commits into from
Dec 18, 2022
Merged

fix(decompress): Exclude '*.nsis' that may cause error #5294

merged 3 commits into from
Dec 18, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Dec 17, 2022 •
edited
Loading

Description

Exclude 0-bit *.nsis when extraction

Motivation and Context

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

rashil2000
rashil2000 previously approved these changes Dec 18, 2022
View reviewed changes
@niheaven niheaven merged commit 257304b into develop Dec 18, 2022
@niheaven niheaven deleted the fix-7z-nsis branch December 18, 2022 15:22
@niheaven niheaven mentioned this pull request Mar 10, 2023
Merged
@goyalyashpal
Copy link

How Has This Been Tested?

image

nice theme :-)

which terminal & theme?

@niheaven
Copy link
Member Author

which terminal & theme?

wt w/ starship

This was referenced May 6, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niheaven @goyalyashpal @rashil2000