cppcryptfs: Add version 1.4.3.5 #5305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash258
suggested changes
Dec 14, 2020
| ["cppcryptfs.exe", "cppcryptfs"] | ||
| ], | ||
| "checkver": "github", | ||
| "depends": "dokany-np" |
There was a problem hiding this comment.
Completely agains scoop's philosophy to depends on non portable application from third party bucket.
Close PR if it does not work without. Marking as invalid until clarified.
There was a problem hiding this comment.
It does for sure not work without dokany. Could also use suggest instead of depends and let the user handle the installation of dokany himself, either via dokany-np or some other manual method.
|
IMO, this package would best be added to the bucket it has a dependency on, in this case the non-portable bucket. |
That's fine with me as well. |
|
I will create a PR for the non-portable bucket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if a nonportable dependency is allowed in the extras bucket.
No
autoupdatebecause it does not work for multiple urls at the moment (ScoopInstaller/Scoop#3518).