Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

television: Add version 0.9.4 #14706

Merged
merged 23 commits into from
Jan 21, 2025
Merged

television: Add version 0.9.4 #14706

merged 23 commits into from
Jan 21, 2025

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Jan 9, 2025 •
edited
Loading

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

fix #14741

Slach added 16 commits October 31, 2023 11:25
@Slach
i2pd browser 1.3.3
a2e291e
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
695a498
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
e8f6aa4
@Slach
Merge branch 'master' of github.com:Slach/scoop-extras-bucket
7470bd3
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
974a48b
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
42e8f59
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
ccfacd0
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
a665e45
@Slach
Merge branch 'master' of github.com:Slach/scoop-extras-bucket
7b4a5e6
@Slach
remove url to allow pass check
bf379d0
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
5ce7db1
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
f2b1d00
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
d970e08
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
4b4e24d
@Slach
Merge branch 'master' of github.com:ScoopInstaller/Extras
e2a3202
@Slach
add tv 0.9.1
88de498
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Your changes do not pass checks.

tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@Slach
Copy link
Contributor Author

Slach commented Jan 9, 2025

/verify

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

All changes look good.

Wait for review from human collaborators.

tv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

danielpauldd
danielpauldd approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@danielpauldd danielpauldd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested manifest. Works as expected.

@danielpauldd
Copy link
Contributor

@Slach there is no corresponding request issue for this PR. Please create one.

aliesbelik
aliesbelik requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please update to the latest version.
  2. I suppose it would be more appropriate to rename manifest to television - same as original project.

bucket/tv.json Outdated Show resolved Hide resolved
bucket/tv.json Outdated Show resolved Hide resolved
Slach and others added 2 commits January 15, 2025 20:11
@Slach @aliesbelik
Update bucket/tv.json after review
c01d433 
Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>
@Slach @aliesbelik
Update bucket/tv.json after review
e8a1f41 
Co-authored-by: Aliaksandr Belik <1752374+aliesbelik@users.noreply.github.com>
@Slach Slach changed the title tv@0.9.1: add tv 0.9.1 television@0.9.1: add television 0.9.1 Jan 15, 2025
@Slach
rename tv to television
e89f265 
Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach Slach changed the title television@0.9.1: add television 0.9.1 television@0.9.2: add television 0.9.2 Jan 15, 2025
@Slach
Copy link
Contributor Author

Slach commented Jan 15, 2025

@danielpauldd why CI/CD failed?

Error: [-] files end with a newline 67ms (66ms|1ms)

but, i already added it
look 3bba5e3

I don't understand how it possible
and why
https://github.com/Slach/scoop-extras-bucket/blame/add_tv/bucket/television.json
show only 24 lines
but contains 25 lines actually
image

why we need so stupid check? this is still valid JSON

@aliesbelik aliesbelik changed the title television@0.9.2: add television 0.9.2 television: Add version 0.9.2 Jan 16, 2025
@aliesbelik
Copy link
Collaborator

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

television

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik
Copy link
Collaborator

/verify

@github-actions GitHub Actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

television

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@aliesbelik aliesbelik mentioned this pull request Jan 21, 2025
Open
1 task
@aliesbelik aliesbelik changed the title television: Add version 0.9.2 television: Add version 0.9.4 Jan 21, 2025
@aliesbelik aliesbelik merged commit 4193854 into ScoopInstaller:master Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpauldd danielpauldd danielpauldd approved these changes

@aliesbelik aliesbelik aliesbelik approved these changes

Assignees
No one assigned
Labels
review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: television fuzzy find
3 participants
@Slach @danielpauldd @aliesbelik