Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New images for mpl3x2 changes #31

Merged
merged 2 commits into from
Mar 18, 2020
Merged

New images for mpl3x2 changes #31

merged 2 commits into from
Mar 18, 2020

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Mar 18, 2020

More fallout from matplotlib v3.2
Onwards from #29 -- more was needed to fix.

@pp-mo pp-mo requested a review from trexfeathers March 18, 2020 11:49
@pp-mo pp-mo mentioned this pull request Mar 18, 2020
Merged
trexfeathers
trexfeathers requested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes match the original 12 failures that Iris PR 3682 addresses, however the latest commit for 3682 has highlighted some new failures that need investigating. Assuming the investigation yields more new image hashes we should get them all into this PR so this should not be merged yet.

@pp-mo
Copy link
Member Author

pp-mo commented Mar 18, 2020

Hi @trexfeathers thanks for your patience.
I think all those extra failures are ones that only emerge on a re-run when you have fixed the first set of errors. Which I forgot to do ..
Ironically, just one of the things I have just been painstakingly re-documenting.

@trexfeathers
Copy link
Contributor

Ironically, just one of the things I have just been painstakingly re-documenting.

Hadn't escaped my notice 😂

trexfeathers
trexfeathers approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm the latest 7 additions address the additional 7 failures highlighted here. All good, thanks @pp-mo 👍

@trexfeathers trexfeathers merged commit 35d9aa8 into SciTools:gh-pages Mar 18, 2020
@pp-mo pp-mo deleted the fix_mpl3x2 branch March 18, 2020 16:57
@pp-mo pp-mo mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trexfeathers trexfeathers trexfeathers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp-mo @trexfeathers