Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide cubestr fix 3v0vx #4230

Closed
wants to merge 3 commits into from
Closed

Wide cubestr fix 3v0vx #4230

wants to merge 3 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jul 7, 2021

🚀 Pull Request

Fix bugs in cube printout, including critical failure for ancillaries with overlong names

Include the #4124 changes as a bugfix to v3
(also added whatsnew)

This is already on 'main', but there I missed off the whatsnew.
No need to address that I think, because this code has no longterm future, due to #4206

WIP because ...

  • probably do not want to consider this for v3.0.3
  • wait for 3.0.4
    (update : following v3.0.3 release -- now good to go ! )

I see we have no whatsnew/latest.rst on the bugfix branch.
So I hope creating a '3.0.4' whatsnew is the correct way with this.


Consult Iris pull request check list

@pp-mo pp-mo marked this pull request as draft July 7, 2021 17:10
@pp-mo pp-mo requested review from bjlittle and rcomer July 7, 2021 17:13
@bjlittle bjlittle self-assigned this Jul 7, 2021
@rcomer rcomer removed their request for review July 7, 2021 18:55
@pp-mo pp-mo marked this pull request as ready for review July 8, 2021 09:03
@pp-mo pp-mo closed this Jul 8, 2021
@pp-mo pp-mo reopened this Jul 8, 2021
@pp-mo pp-mo closed this Jul 8, 2021
@pp-mo pp-mo reopened this Jul 8, 2021
@pp-mo pp-mo closed this Jul 8, 2021
@pp-mo
Copy link
Member Author

pp-mo commented Jul 12, 2021

Replaced by #4233

@bjlittle bjlittle deleted the wide_cubestr_fix_3v0vx branch September 22, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants