whatsnew entry for dependencies #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
commented
Sep 8, 2020
| @@ -1198,7 +1198,7 @@ def _check(item): | |||
|
|
|||
| class DimCoordMetadata(CoordMetadata): | |||
| """ | |||
| Metadata container for a :class:`~iris.coords.DimCoord" | |||
| Metadata container for a :class:`~iris.coords.DimCoord` | |||
There was a problem hiding this comment.
@tkknight This was just wrong, and causing a documentation warning during sphinx build time.
bjlittle
commented
Sep 8, 2020
|
|
||
| * Iris now requires `Cartopy <https://github.com/SciTools/cartopy>`_ >= 0.18 in | ||
| order to remain compatible with the latest version of | ||
| `Matplotlib <https://github.com/matplotlib/matplotlib>`_. | ||
| order to remain compatible with the latest version of `Matplotlib`_. |
There was a problem hiding this comment.
@tkknight There ended up being two matplotlib references...
bjlittle
commented
Sep 8, 2020
| @@ -22,6 +22,4 @@ | |||
| ax.coastlines(resolution="50m") | |||
| ax.gridlines() | |||
|
|
|||
| plt.tight_layout() | |||
|
|
|||
|
Looks good @bjlittle. |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 9, 2020
* master: Fix sphinx logger (SciTools#3832) whatsnew entry for dependencies (SciTools#3831) Added link to scitools.org.uk on the main index. (SciTools#3830)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 9, 2020
* master: Fix sphinx logger (SciTools#3832) whatsnew entry for dependencies (SciTools#3831) Added link to scitools.org.uk on the main index. (SciTools#3830)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 11, 2020
* master: (36 commits) Rework whatsnew into new scheme. (SciTools#3834) Lazy regridding with Linear, Nearest, and AreaWeighted (SciTools#3701) Iris readme minimal (SciTools#3833) Fix sphinx logger (SciTools#3832) whatsnew entry for dependencies (SciTools#3831) Added link to scitools.org.uk on the main index. (SciTools#3830) Updated Iris install instructions (SciTools#3817) Delete labeler.yml Delete label.yml Create label.yml Delete labeler.yml Update labeler.yml Update labeler.yml Add template collapsible markdown section (SciTools#3823) Requirements re-haul (SciTools#3812) Automate pull request labels (SciTools#3819) move whatsnew contributions (SciTools#3816) Parse with packaging version (SciTools#3815) Add "What's New" entries for unpinning Cartopy, Matplotlib, Proj (SciTools#3811) tidy issue templates (SciTools#3814) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
whatsnewentry for #3812.It also addresses several minor documentation issues that have unfortunately crept in 🤔
We need to fix the
sphinxlogger issue #3789