Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery code consistency #3766

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Gallery code consistency #3766

merged 4 commits into from
Aug 3, 2020

Conversation

tkknight
Copy link
Contributor

Minor PR to:

  • Tidy up imports on gallery code
  • Remove old init.py

tkknight added 2 commits July 22, 2020 10:44
@tkknight
Tidy up gallery code
cd95bda
@tkknight
Merge branch 'master' into gallery_code_consistency
89f2ef2 
* master:
  pin matplotlib<3.3 (SciTools#3763)
  moved to oceanography section of gallery (SciTools#3761)
  unpin cftime (SciTools#3757)
  flake8 outstanding files (SciTools#3755)
  Numpy rounding fix (SciTools#3758)
@tkknight tkknight requested a review from bjlittle July 30, 2020 11:04
@bjlittle bjlittle self-assigned this Aug 3, 2020
@bjlittle
Copy link
Member

bjlittle commented Aug 3, 2020

@tkknight Thanks for this...

However, in terms of imports we've adopted the following style to group imports into the following blocks:

  1. import Python builtin modules i.e., those modules that ship with Python e.g., collections, datetime etc
  2. import third-party modules i.e., those modules that are not part of iris nor Python e.g., cftime, matplotlib, numpy etc
  3. import iris specific modules i.e., those modules that are part of iris e.g., iris.coord, iris.cube, iris.plot etc

The blocks of imports are separated by blank lines, and within each block the modules are listed alphabetically

@bjlittle
Copy link
Member

bjlittle commented Aug 3, 2020

@tkknight Awesome, thanks 👍

@bjlittle bjlittle merged commit b22fbfd into SciTools:master Aug 3, 2020
tkknight added a commit to tkknight/iris that referenced this pull request Aug 3, 2020
@tkknight
Merge branch 'master' into whatsnew_simpler_with_documentation
a04e8db 
* master:
  Gallery code consistency (SciTools#3766)
  enabled pdf creation (SciTools#3765)
tkknight added a commit to tkknight/iris that referenced this pull request Aug 14, 2020
@tkknight
Merge branch 'master' into napolean
349f596 
* master:
  remove duplicate whats new entries from the last release (SciTools#3773)
  whatsnew latest update (SciTools#3771)
  whatsnew overhaul (SciTools#3769)
  Gallery code consistency (SciTools#3766)
  enabled pdf creation (SciTools#3765)
tkknight added a commit to tkknight/iris that referenced this pull request Aug 15, 2020
@tkknight
Merge branch 'master' into contribution_overhaul
13de816 
* master:
  remove duplicate whats new entries from the last release (SciTools#3773)
  whatsnew latest update (SciTools#3771)
  whatsnew overhaul (SciTools#3769)
  Gallery code consistency (SciTools#3766)
  enabled pdf creation (SciTools#3765)
  pin matplotlib<3.3 (SciTools#3763)
  moved to oceanography section of gallery (SciTools#3761)
  unpin cftime (SciTools#3757)
  flake8 outstanding files (SciTools#3755)
  Numpy rounding fix (SciTools#3758)
owena11 pushed a commit to owena11/iris that referenced this pull request Aug 19, 2020
@tkknight @owena11
Gallery code consistency (SciTools#3766)
660fd34 
Tidy up gallery code
@tkknight tkknight deleted the gallery_code_consistency branch September 10, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle left review comments

Assignees

@bjlittle bjlittle

Labels
Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkknight @bjlittle