Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete test. #3662

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove obsolete test. #3662

merged 1 commit into from
Feb 20, 2020

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Feb 19, 2020

The patch which this tests is long since gone.

From a ticket on our very old pre-github FCM project ...

From: Daniel Varela Santoalla [mailto:dvarela@ecmwf.int] 
Sent: 02 March 2012 17:40
To: Blay, Byron; Green, Thomas
Cc: Hodkinson, Mark; software support; advisory
Subject: Re: GRIB API bug (ref SUP-87)

Hi Byron and Thomas

This bug in the python interface was fixed some time ago and will be included
in the next release, 1.9.14, which will be released very soon. However, if you
are in an urgent need of a solution you could apply the following patch.


Index: python/grib_interface.c
===================================================================
diff -u -N -r51092 -r60810
--- python/grib_interface.c	(.../grib_interface.c)	(revision 51092)
+++ python/grib_interface.c	(.../grib_interface.c)	(revision 60810)
@@ -1562,7 +1562,7 @@
 
   if(!h) return GRIB_INVALID_GRIB;
 
-  return grib_get_double(h, key, val);
+  return grib_set_double(h, key, *val);
 }
 
 int grib_c_get_real8_element(int* gid, char* key,int* index, double* val){




Best regards
Daniel Varela
ECMWF Software support

@pp-mo pp-mo requested a review from lbdreyer February 19, 2020 19:11
@lbdreyer lbdreyer mentioned this pull request Feb 19, 2020
Closed
10 tasks
@lbdreyer
Copy link
Member

👍

@lbdreyer lbdreyer merged commit e2ed1a6 into SciTools:master Feb 20, 2020
MoseleyS added a commit to MoseleyS/iris that referenced this pull request Mar 6, 2020
@MoseleyS
Merge branch 'master' into nimrod_file_format
5e63577 
* master:
  Remove TestGribMessage (SciTools#3672)
  Removed iris.tests.integration.test_grib_load and related CML files. (SciTools#3670)
  Removed grib-specific test to iris-grib. (SciTools#3671)
  Fixed asv project name to 'scitools-iris'. (SciTools#3660)
  Remove cube iter (SciTools#3656)
  Remove test_grib_save.py (SciTools#3669)
  Remove test_grib2 integration tests (SciTools#3664)
  Remove uri callback test which is moved to iris-grib (SciTools#3665)
  2v4 mergeback picks (SciTools#3668)
  Remove test_grib_save_rules.py which has been moved to iris-grib (SciTools#3666)
  Removed ununused skipIf. (SciTools#3632)
  Remove grib-specific test. (SciTools#3663)
  Remove obsolete test. (SciTools#3662)
  remove redundant tests (SciTools#3650)
  Fixed tests since Numpy 1.18 deprecation of non-int num arguments for linspace. (SciTools#3655)
trexfeathers added a commit that referenced this pull request Mar 18, 2020
@pp-mo @trexfeathers
@bjlittle @lbdreyer @jonseddon
Update ng-vat with recent changes+fixes from master (#3685)
df579a3 
* Fixed tests since Numpy 1.18 deprecation of non-int num arguments for linspace. (#3655)

* remove redundant tests (#3650)

* Remove obsolete test. (#3662)

* Remove grib-specific test. (#3663)

* Removed ununused skipIf. (#3632)

* Remove test_grib_save_rules.py which has been moved to iris-grib (#3666)

* 2v4 mergeback picks (#3668)

* Stop PPDataProxy accessing the file when no data is needed. (#3659)

* Add 2.4 whatsnew into full whatsnew list.

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Remove uri callback test which is moved to iris-grib (#3665)

* Remove test_grib2 integration tests (#3664)

* Remove test_grib_save.py (#3669)

* Remove cube iter (#3656)

* Fixed asv project name to 'scitools-iris'. (#3660)

* Removed grib-specific test to iris-grib. (#3671)

* Removed iris.tests.integration.test_grib_load and related CML files. (#3670)

* Remove TestGribMessage (#3672)

* Switched use of datetime.weekday() to datetime.dayofwk. (#3687)

* New image hashes for mpl 3x2 (#3682)

* New image hash for iris.test.test_plot.TestSymbols.test_cloud_cover with matplotlib 3.2.0.

* Further images changes for mpl3x2.

* Yet more updated image results.

* Correct and improve dev-guide section on fixing graphics-tests. (#3683)

* Correct and improve dev-guide section on fixing graphics-tests.

* Review changes + general rethink.

* Reduce duplication between 'graphics-tests' and general 'tests' page.

* Update docs/iris/src/developers_guide/graphics_tests.rst

Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Update docs/iris/src/developers_guide/graphics_tests.rst

Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Update docs/iris/src/developers_guide/graphics_tests.rst

Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Update docs/iris/src/developers_guide/graphics_tests.rst

Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Update docs/iris/src/developers_guide/graphics_tests.rst

Co-Authored-By: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Co-authored-by: Bill Little <bill.james.little@gmail.com>
Co-authored-by: lbdreyer <lbdreyer@users.noreply.github.com>
Co-authored-by: Jon Seddon <17068361+jonseddon@users.noreply.github.com>
stephenworsley added a commit to stephenworsley/iris that referenced this pull request Jun 8, 2020
@stephenworsley
Merge branch 'default_units' of https://github.com/SciTools/iris into…
4f267ad 
… default_units_patch

* 'default_units' of https://github.com/SciTools/iris:
  Unify saving behaviour of "unknown" and "no_unit" (SciTools#3711)
  Change default loading unit from "1" to "unknown" (correct branch) (SciTools#3709)
  Change default units to "unknown" for all DimensionalMetadata (SciTools#3713)
  Update docs CubeList.extract method (SciTools#3694)
  Correct and improve dev-guide section on fixing graphics-tests. (SciTools#3683)
  New image hashes for mpl 3x2 (SciTools#3682)
  Switched use of datetime.weekday() to datetime.dayofwk. (SciTools#3687)
  Remove TestGribMessage (SciTools#3672)
  Removed iris.tests.integration.test_grib_load and related CML files. (SciTools#3670)
  Removed grib-specific test to iris-grib. (SciTools#3671)
  Fixed asv project name to 'scitools-iris'. (SciTools#3660)
  Remove cube iter (SciTools#3656)
  Remove test_grib_save.py (SciTools#3669)
  Remove test_grib2 integration tests (SciTools#3664)
  Remove uri callback test which is moved to iris-grib (SciTools#3665)
  2v4 mergeback picks (SciTools#3668)
  Remove test_grib_save_rules.py which has been moved to iris-grib (SciTools#3666)
  Removed ununused skipIf. (SciTools#3632)
  Remove grib-specific test. (SciTools#3663)
  Remove obsolete test. (SciTools#3662)
tkknight pushed a commit to tkknight/iris that referenced this pull request Jun 29, 2020
@pp-mo @tkknight
Remove obsolete test. (SciTools#3662)
f0fd41d
@pp-mo pp-mo deleted the remove_gribpatch_test branch February 17, 2021 14:47
@rcomer rcomer mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbdreyer lbdreyer Awaiting requested review from lbdreyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp-mo @lbdreyer