Stock #2212
Merged
Stock #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marqh
commented
Oct 25, 2016
- move stock npy arrays to iris-test-data stock arrays iris-test-data#45
- update skip_data pattern usage
- alter minimal testing environment to not use test_data
pp-mo
reviewed
Oct 25, 2016
| @@ -183,7 +183,10 @@ def get_data_path(relative_path): | |||
| """ | |||
| if not isinstance(relative_path, six.string_types): | |||
| relative_path = os.path.join(*relative_path) | |||
| data_path = os.path.join(iris.config.TEST_DATA_DIR, relative_path) | |||
| test_data_dir = iris.config.TEST_DATA_DIR | |||
| if test_data_dir is None: | |||
There was a problem hiding this comment.
I don't see the need for this..
From how iris.config.TEST_DATA_DIR is initialised in iris.config, I think this can't be empty ?
There was a problem hiding this comment.
it can occur, here:
https://github.com/SciTools/iris/blob/master/lib/iris/config.py#L138
override = os.environ.get("override_test_data_repository")
if override:
if override == '1':
TEST_DATA_DIR = None
else:
TEST_DATA_DIR = override
pp-mo
reviewed
Oct 25, 2016
| class TestBasic(tests.GraphicsTest): | ||
| cube = iris.tests.stock.realistic_4d() | ||
| def setUp(self): | ||
| self.cube = iris.tests.stock.realistic_4d() |
There was a problem hiding this comment.
Needs to call the class setUp here :
super(TestBasic, self).setUp()
|
As a cross-check, I ran all tests with control exports:
The only failure is this one : So, that needs wrapping with "skip_data". |
marqh
added a commit
to marqh/iris
that referenced
this pull request
Oct 26, 2016
* move stock arrays to test data
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.