-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add 'main' conda-forge channel; fix for eccodes >= 1.19 #240
Conversation
Ok, so the key problem is that ECMWF have changed a default parameter setting for GRIB1 messages. All the problems are with GRIB1 files in iris-test-data, that now read back differently, From comparing release downloads of eccodes, the key change seems to be in a file
Whereas in 1.19 this last line changed to ... In the release notes , Bug Fixes section, we have Unfortunately the issue content may be private -- I can't view it but @lbdreyer can ? |
I've posted a 'fix' to that gribapi change. |
iris_grib/__init__.py
Outdated
# However, this does not match 'radiusOfTheEarth' and may be incorrect : We may change it in future. | ||
soe_code = 6 | ||
if soe_code == 0: | ||
# New supposedly-correct correct value, matches the 'radiusOfTheEarth' parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional, you are hardcoding soe_code
to be 6, but including the if soe_code == 0
for future, if we decide to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I thought I should remove most of the previous unused options, but I left both these ones in for reference.
Looks good to me! |
* upstream/v0.16.x: Docstest 0v16 (SciTools#244) Remove eccodes bug workaround added in SciTools#208. (SciTools#224) Update requirements to pick up Iris 3. (SciTools#243) Add 'main' conda-forge channel, needed for docs builds. (SciTools#240) Fix RC date in release notes (about to cut). (SciTools#235) Version 0.16 release candidate (SciTools#232) Cosmetic change : rename the travis iris-test-version options (SciTools#234) Travis test with both Iris latest-release and latest-master. (SciTools#231)
* Add 'main' conda-forge channel, needed for docs builds. * Use fixed spherical-earth-radius in GRIB1, ignoring change in gribapi default. * Codestyle fix.
* Travis test with both Iris latest-release and latest-master. (#231) * Travis test with both Iris latest-release and latest-master. * Modify test CMLs for latest Iris (Iris3.0 changes). * Grib1 load fixes. * Fix loading since units=None default for Iris3 coords * Modify test to work with latest Iris (Iris3.0 changes). * Test against latest Iris only. * Review changes. * Cosmetic change : rename the travis iris-test-version options (#234) * Rename Iris test-version options, and enable all to check action. * Review changes. * Version 0.16 release candidate (#232) * Require Iris >=3 (just for the gdt90 changes). * Whatsnew entry for requiring Iris 3. * Set version string for release candidate. * Test against Iris 3.0.0rc0 from conda-forge/rc_iris. * Fix RC date in release notes (about to cut). (#235) * Add 'main' conda-forge channel, needed for docs builds. (#240) * Add 'main' conda-forge channel, needed for docs builds. * Use fixed spherical-earth-radius in GRIB1, ignoring change in gribapi default. * Codestyle fix. * Update requirements to pick up Iris 3. (#243) * Remove eccodes bug workaround added in #208. (#224) * Docstest 0v16 (#244) * Document PR#240 in release notes. * Fix version string and release-notes date. * Added getting started .cirrus.yml * Update cirrus to use miniconda image * Update .cirrus.yml * Update .cirrus.yml Copied across cirrus file from iris-ugrid * Added nox testing Borrowing from iris and iris-ugrid, added nox testing and a test runner. Tests currently fail on my local machine. * Path fixes in cirrus.yml * eccodes test added to noxfile * Added config and coverage * Trying to set SITE_CFG * syntax error * taking the IRIS_DIR from Travis CI config * Add allow_failures to the linux task for now * Dodgy r key... * Update .cirrus.yml * Allow failures in linting * Force return error 0 for now * Added eccodes test * moved matrix * Yaml syntax error & * wrong way around * Typo * Update iris version dependency * Date fix This resolves the same bash issue as SciTools/iris#4019 * Configure Iris in nox * Updated CI config * correct site-packages path * Fix to iris test data path * force cache update * refactored writing iris config in noxfile * Fix pep8 and license test fails * Support for testing against packaged iris and building from source * Adding yaml to list of cirrus container requirements * invalidate cirrus cache * really invalidate cirrus cache... * yaml -> pyyaml * missing iris_dir reference * call write_iris_config * docstrings and matrix testing * git syntax error * eccodes selfcheck in basic tests * Removed py3.8 testing for now * Fixed regression in setup.py test * Removed unused imports * Disabled lint checking * Removed nox from test dependencies for python3.6 and python3.8 * Removed python3.8 from noxfile * Removed nox from test requirements Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
This fixes the RTD docs-build error which emerged following the cut of the original 0.16.0rc0 pre-release tag.
Given the error seen in the attempt to re-spin #224 today, we suspect those errors will come through here too
(something to do with ellipsoid definitions changing)
So we will probably want to wait until that is fixed before merging this ...