Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing masks for nearest scheme #369

Closed
wants to merge 6 commits into from

Conversation

bouweandela
Copy link
Member

Closes #368

@bouweandela bouweandela marked this pull request as ready for review June 18, 2024 11:37
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (fdd2051) to head (83cf362).

Files Patch % Lines
esmf_regrid/esmf_regridder.py 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   98.92%   98.94%   +0.01%     
==========================================
  Files          37       37              
  Lines        4196     4265      +69     
==========================================
+ Hits         4151     4220      +69     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

@SciTools/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 180 days. Remove stale label or comment, otherwise this pull-request will close automatically in 14 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Mar 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (fdd2051) to head (83cf362).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
esmf_regrid/esmf_regridder.py 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   98.92%   98.94%   +0.01%     
==========================================
  Files          37       37              
  Lines        4196     4265      +69     
==========================================
+ Hits         4151     4220      +69     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Mar 5, 2025
@bouweandela
Copy link
Member Author

I'm fine with letting this go stale. Will reopen when I have time to work on this again, hopefully in a few months time.

@bouweandela bouweandela closed this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

use_src_mask and use_tgt_mask with nearest regridding scheme do not produce correct results
3 participants