FIX: Don't reset datalims in contour, only update/expand #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contour(f) previously updated the datalims with ignore=None, which takes the last value that must have been True to ignore the current data limits. We only want to update what was previously there, not override that box and potentially shrink the limits.
|
Wow, thanks for the speedy fix @greglucas! Are there likely to be any more patch releases for v0.19, or will this fix now wait for v0.20? The issue is causing test failures in Iris, so I'm just wondering whether we need to put a workaround into Iris's upcoming patch release. |
|
Good question @rcomer, I'm not sure if we will do a minor release or not... My guess is that even if we were to do a minor release it would be a while before that happened, so it is probably better to patch Iris if you can. |
|
I'm going to self-merge based on @rcomer's review and this has tests. It should be included in the next release. |
|
I don't have merge rights here, but can confirm the change looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contour(f) previously updated the datalims with ignore=None, which
takes the last value (that must have been True to ignore the current
data limits). We only want to update what was previously there, not
override that box and potentially shrink the limits.
Closes #1780