User Registration with Profile Fields

[logerzerox]

🎯 Problem
Previously, setting user profile fields (name, bio, profile_picture) required two API calls:

1. Register user with email/password
2. Update user to add profile fields

This caused verification emails to use email prefix instead of actual name since the name was set after registration.

💡 Solution
Combined registration and profile update into a single API call by:

• Adding profile fields to initial user registration
• Removing the separate update call after registration
• Ensuring verification emails use actual name immediately

---

Important

Combine user registration and profile update into a single API call, ensuring immediate use of profile fields in verification emails.

• Behavior:
  • Combine user registration and profile update into a single API call in users_router.py.
  • Remove separate update call after registration in users_router.py.
  • Ensure verification emails use actual name immediately in r2r_auth.py.
• Database:
  • Update create_user in users.py to accept name, bio, and profile_picture during registration.
  • Modify register in r2r_auth.py and supabase.py to handle new profile fields.
• Services:
  • Update register in auth_service.py to pass profile fields to providers.
• Misc:
  • Comment out unused update logic in users_router.py.

^{This description was created by for 5d91432. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5d91432 in 1 minute and 35 seconds

More details

• Looked at 163 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. py/core/database/users.py:291

• Draft comment:
  Ensure that the fields 'name', 'bio', and 'profile_picture' are handled correctly when they are None. This can be done by using a default value or handling null values from the database.
• Reason this comment was not posted:
  Comment did not seem useful.

2. py/core/main/services/auth_service.py:46

• Draft comment:
  Consider adding validation for the 'name', 'bio', and 'profile_picture' parameters to ensure they meet any necessary requirements (e.g., length, format).
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The validation suggestion seems reasonable at first glance, but several things make me doubt its usefulness: 1) These parameters are Optional, so they can be None 2) The same parameters are used elsewhere without validation 3) The validation would likely be handled in the auth provider layer, not here 4) Without knowing the requirements, we can't be sure validation is even needed 5) The comment is speculative - it's not pointing out a clear issue.
  I might be wrong about where validation should occur - maybe this service layer is exactly where it belongs. Also, lack of validation elsewhere doesn't mean it's not needed here.
  While those are fair points, the comment still fails our core rules: it's speculative ("if needed"), not clearly actionable (no specific requirements given), and assumes validation isn't handled elsewhere.
  The comment should be deleted because it's speculative and not clearly actionable without more context about validation requirements and where validation should occur in the architecture.

3. py/core/providers/auth/r2r_auth.py:198

• Draft comment:
  Consider adding validation for the 'name', 'bio', and 'profile_picture' parameters to ensure they meet any necessary requirements (e.g., length, format).
• Reason this comment was not posted:
  Marked as duplicate.

4. py/core/providers/auth/supabase.py:75

• Draft comment:
  Consider adding validation for the 'name', 'bio', and 'profile_picture' parameters to ensure they meet any necessary requirements (e.g., length, format).
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_dqxhC8Goll1C3AXO

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[NolanTrem]

Looks pretty good! A few small changes requested. Can you also make sure to run poetry run pre-commit run --all-files from the /py directory? No need to worry about the mypy type checking errors, as these are on main, but the rest should all pass.

[NolanTrem]

Nit: Let's move this to keyword arguments, rather than args... i.e.

self.services.auth.register(
email=email,
password=password,
…
)

[NolanTrem]

Feel free to delete this rather than commenting it out

[NolanTrem]

Nit: keyword args rather than positional

[NolanTrem]

Not sure if it's necessary to keep this log, but if we do keep it let's make it more descriptive.

[NolanTrem]

Not something that we need to worry about now, but as we add more email templates in the future it might be nice to move these to proper HTML files.

[NolanTrem]

Also not something to worry about for now, but would be nice to make the colors for emails configurable in the future.