Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default bmp #1775

Merged
merged 1 commit into from
Jan 8, 2025
Merged

change default bmp #1775

merged 1 commit into from
Jan 8, 2025

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jan 8, 2025

Important

Replace asyncio.run() with direct function calls in tests and remove a type ignore comment in extraction.py.

  • Testing:
    • In test_retrieval.py, replace asyncio.run(consume_stream()) with consume_stream() in test_rag_stream_query and test_agent_query_stream.
  • Code Cleanup:
    • Remove # type: ignore comment in extract_kg() in extraction.py.

This description was created by Ellipsis for ca04a00. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review January 8, 2025 04:32
@emrgnt-cmplxty emrgnt-cmplxty merged commit 2b34859 into main Jan 8, 2025
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ca04a00 in 28 seconds

More details
  • Looked at 57 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/tests/integration/test_retrieval.py:89
  • Draft comment:
    Switching from asynchronous to synchronous iteration might cause issues if resp is an async generator. Ensure resp is iterable synchronously or adjust the test accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/tests/integration/test_retrieval.py:123
  • Draft comment:
    Switching from asynchronous to synchronous iteration might cause issues if resp is an async generator. Ensure resp is iterable synchronously or adjust the test accordingly.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_pwII9T0spn3fqqtm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant