Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate /users/register for /users, retrieval bug in list chunks #1693

Closed
wants to merge 2 commits into from

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 13, 2024

Important

Deprecate register method for user creation, replace with create, and add tests for document chunk access and user interactions.

  • Deprecation and Replacement:
    • Deprecate register method in favor of create for user creation in users.ts, auth.py, sync_auth.py, and users.py.
    • Update all relevant test files to use create instead of register.
  • Testing:
    • Add tests for listing document chunks and access control in DocumentsAndCollectionsIntegrationUser.test.ts.
    • Add tests for unauthorized access and non-existent chunk retrieval in runner_chunks.py.
    • Add tests for user and document interactions in runner_user_documents_collections.py.
  • Bug Fixes:
    • Fix bug in documents_router.py related to document chunk retrieval by correcting collection ID handling.
    • Correct SQL query in graph.py for deleting graphs by collection ID.

This description was created by Ellipsis for 3a2f108. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 16434c0 in 1 minute and 22 seconds

More details
  • Looked at 858 lines of code in 26 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/sdk/v2/sync_auth.py:12
  • Draft comment:
    The deprecation message should be updated to reflect the new method name.
    @deprecated("Use client.users.create() instead")
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. py/sdk/v2/auth.py:12
  • Draft comment:
    The deprecation message should be updated to reflect the new method name.
    @deprecated("Use client.users.create() instead")
  • Reason this comment was not posted:
    Marked as duplicate.
3. py/sdk/v3/users.py:62
  • Draft comment:
    The deprecation message should be updated to reflect the new method name.
    @deprecated("Use client.users.create() instead")
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_p6SuqgnB3jFRiGBo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3a2f108 in 30 seconds

More details
  • Looked at 251 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_ZoP20FlCoFLf24mU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem deleted the Nolan/user-endpoint-update branch December 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants