-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KG tests (#1351) #1360
Add KG tests (#1351) #1360
Conversation
* cli tests * add sdk tests * typo fix * change workflow ordering * add collection integration tests (#1352) * bump pkg * remove workflows * fix sdk test port * fix delete collection return check * Fix document info serialization (#1353) * Update integration-test-workflow-debian.yml * pre-commit * slightly modify * up * up * smaller file * up * typo, change order * up * up * change order --------- Co-authored-by: emrgnt-cmplxty <68796651+emrgnt-cmplxty@users.noreply.github.com> Co-authored-by: emrgnt-cmplxty <owen@algofi.org> Co-authored-by: Nolan Tremelling <34580718+NolanTrem@users.noreply.github.com>
* add documentation * up * Update js/sdk/src/models.tsx Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * pre-commit --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Co-authored-by: Simeon <simeon@theobald.nz>
* cleanups * add back overzealous edits * extend workflows * fix full setup * simplify cli * add ymls * rename to light * try again * start light * add cli tests * fix * fix * testing.. * trying complete matrix testflow * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * up * up * up * All actions * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * try offic pgvec formula * sudo make * sudo make * push and pray * push and pray * add new actions * add new actions * docker push & pray * inspect manifests during launch * inspect manifests during launch * inspect manifests during launch * inspect manifests during launch * setup docker * setup docker * fix default * fix default
* cleanups * add back overzealous edits * extend workflows * fix full setup * simplify cli * add ymls * rename to light * try again * start light * add cli tests * fix * fix * testing.. * trying complete matrix testflow * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * cleanup matrix logic * up * up * up * All actions * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * rename to runner * try offic pgvec formula * sudo make * sudo make * push and pray * push and pray * add new actions * add new actions * docker push & pray * inspect manifests during launch * inspect manifests during launch * inspect manifests during launch * inspect manifests during launch * setup docker * setup docker * fix default * fix default * make changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to a1ba8be in 1 minute and 20 seconds
More details
- Looked at
4128
lines of code in75
files - Skipped
4
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. templates/webdev/app/api/rag/route.ts:11
- Draft comment:
Hardcoding credentials is a security risk. Consider using environment variables or a secure vault for authentication. - Reason this comment was not posted:
Marked as duplicate.
2. templates/webdev/app/api/search/route.ts:11
- Draft comment:
Hardcoding credentials is a security risk. Consider using environment variables or a secure vault for authentication. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_C5e5v9hwTWZbDIE1
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
|
||
try { | ||
// Login with each request. In a production app, you'd want to manage sessions. | ||
await client.login("admin@example.com", "change_me_immediately"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding credentials is a security risk. Consider using environment variables or a secure vault for authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f1cb118 in 22 seconds
More details
- Looked at
85
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. .github/actions/setup-postgres-ext/action.yml:40
- Draft comment:
Consider parameterizing the pgvector version or using a dynamic method to fetch the latest version to avoid hardcoding the URL. - Reason this comment was not posted:
Confidence changes required:50%
The Windows setup script for PostgreSQL includes a hardcoded download URL for pgvector. This could break if the URL changes or if a new version is released. It's better to parameterize the version or use a more dynamic method to fetch the latest version.
Workflow ID: wflow_0Rtl7tIPTpPdXAO1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 5a4df92 in 36 seconds
More details
- Looked at
71
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_sLma9c98N7iv6Y8G
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
cmd.exe /c "call `"$vcvars64Path`" && set > %temp%\vcvars.txt" | ||
Get-Content "$env:temp\vcvars.txt" | Foreach-Object { | ||
if ($_ -match "^(.*?)=(.*)$") { | ||
Set-Content "env:\$($matches[1])" $matches[2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Set-Item
instead of Set-Content
to set environment variables in PowerShell.
Set-Content "env:\$($matches[1])" $matches[2] | |
Set-Item "env:\$($matches[1])" $matches[2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a8c252a in 20 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/pyproject.toml:8
- Draft comment:
Ensure that the version bump to3.2.10
is reflected in all relevant documentation and changelogs to maintain consistency across the project. - Reason this comment was not posted:
Confidence changes required:50%
The version bump in the pyproject.toml file is consistent with the PR description, which mentions a version update. This is a minor version bump, indicating backward-compatible changes or additions.
Workflow ID: wflow_XlX71mTXKgMI5Zo3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
cli tests
add sdk tests
typo fix
change workflow ordering
add collection integration tests (add collection integration tests #1352)
bump pkg
remove workflows
fix sdk test port
fix delete collection return check
Fix document info serialization (Fix document info serialization for Hatchet orchestration #1353)
Update integration-test-workflow-debian.yml
pre-commit
slightly modify
up
up
smaller file
up
typo, change order
up
up
change order
Important
Add integration tests for KG features and introduce a Next.js web development template with R2R support.
runner_cli.py
.runner_sdk.py
.templates/webdev
with Tailwind CSS for styling.templates/webdev/app/api
.templates/webdev
..gitignore
andLICENSE.txt
for the web development template.This description was created by for a8c252a. It will automatically update as commits are pushed.