cleanup step! and make it return whether the step was sucessful
#2587
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by https://discourse.julialang.org/t/how-can-i-check-if-step-was-successful/125581, there isn't currently a good way to check whether `step!` succeeds. This makes it return a bool for whether it worked, and also removes a bunch of `@inbounds` statements that don't do anything since `@inbounds` doesn't traverse function boundaries.
ChrisRackauckas
approved these changes
Feb 5, 2025
|
The only question here to me is whether we want to return a bool or the retcode. |
|
A retcode would be good if we have it at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by https://discourse.julialang.org/t/how-can-i-check-if-step-was-successful/125581, there isn't currently a good way to check whether
step!succeeds. This makes it return a bool for whether it worked, and also removes a bunch of@inboundsstatements that don't do anything since@inboundsdoesn't traverse function boundaries.