Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for differential_vars update #278

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Fix for differential_vars update #278

merged 3 commits into from
Dec 16, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@devmotion devmotion mentioned this pull request Dec 15, 2023
5 tasks
@@ -20,7 +20,6 @@ jobs:
matrix:
version:
- '1'
- '1.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could still be useful to keep testing the oldest compatible version explicitly since 1.10 will be released soon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess. I think we'll just need to update a lot of package CIs anyways. We'll want to just bump things to v1.10 since that's the suggested LTS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not going to worry about this right now, but you can put a PR if you want to do that. I think when v1.10 comes out, since that's poised to be right after a huge round of a major bumps, I think we'll just bump packages to v1.10 and backport what's needed, and then hopefully that's the new LTS.

Project.toml Outdated
@@ -18,7 +18,7 @@ SimpleNonlinearSolve = "727e6d20-b764-4bd8-a329-72de5adea6c7"
SimpleUnPack = "ce78b400-467f-4804-87d8-8f486da07d0a"

[compat]
ArrayInterface = "6, 7"
ArrayInterface = "7"
DataStructures = "0.18"
DiffEqBase = "6.122"
OrdinaryDiffEq = "6.49.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this require an OrdinaryDiffEq version bump?

@@ -27,4 +27,4 @@ Reexport = "0.2, 1.0"
SciMLBase = "1.90, 2"
SimpleNonlinearSolve = "0.1, 1"
SimpleUnPack = "1"
julia = "1.6"
julia = "1.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since OrdinaryDiffEq dropped support for < 1.9?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ChrisRackauckas ChrisRackauckas merged commit 122af53 into master Dec 16, 2023
10 of 11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the differential_vars branch December 16, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants