Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower compat bounds and downgrade tests #45

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Apr 18, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The compat bounds for ChainRulesCore and EnzymeCore were the most recent ones. I relaxed them to versions where I am sure that the necessary objects already exist, and added a downgrade compat test on Julia 1.10

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e67bf3) to head (ca45982).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           64        64           
=========================================
  Hits            64        64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle requested a review from Vaibhavdixit02 April 18, 2024 18:17
@Vaibhavdixit02 Vaibhavdixit02 merged commit aa2429e into main Apr 18, 2024
5 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the gd/lowerbounds branch April 18, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants