Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for integration testing #264

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Setup for integration testing #264

merged 4 commits into from
Jan 14, 2025

Conversation

jl-wynen
Copy link
Collaborator

This should help us set up integration tests that get started by upstream projects (e.g., the backend).

@jl-wynen jl-wynen requested a review from Junjiequan January 13, 2025 11:14
@jl-wynen jl-wynen force-pushed the setup-for-integration-testing branch from 10f8a8a to 9e1fef0 Compare January 13, 2025 11:56
Comment on lines 3 to 40
on:
workflow_dispatch:
inputs:
os-variant:
default: 'ubuntu-24.04'
type: string
description: 'Operating system'
python-version:
type: string
description: 'Python interpreter version'
tox-env:
default: 'test'
type: string
description: 'Tox environment to run'
checkout_ref:
default: ''
type: string
description: 'Git ref to checkout'
workflow_call:
inputs:
os-variant:
default: 'ubuntu-24.04'
type: string
python-version:
type: string
tox-env:
default: 'test'
type: string
checkout_ref:
default: ''
type: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also include a scicat backend version input in the workflow_dispatch and workflow_call? so that when we trigger the workflow we can trigger the workflow with specific version, e.g, v4.8.0 or latest or stable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Do we need to make more changes to make it callable from the backend project?

Copy link
Member

@Junjiequan Junjiequan Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than above comment I have not spotted any major things. I think we can start with this workflow and see how it works together. I will add a workflow for this on scicat backend next week as I have quite a few tickets on hand at the moment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it. You should be able to trigger the workflow now. Let me know how it goes!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do, thanks!

@jl-wynen jl-wynen force-pushed the setup-for-integration-testing branch from 9e1fef0 to c9c3072 Compare January 14, 2025 12:52
@jl-wynen jl-wynen merged commit e38edc6 into main Jan 14, 2025
12 checks passed
@jl-wynen jl-wynen deleted the setup-for-integration-testing branch January 14, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants