-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for integration testing #264
Conversation
10f8a8a
to
9e1fef0
Compare
.github/workflows/test.yml
Outdated
on: | ||
workflow_dispatch: | ||
inputs: | ||
os-variant: | ||
default: 'ubuntu-24.04' | ||
type: string | ||
description: 'Operating system' | ||
python-version: | ||
type: string | ||
description: 'Python interpreter version' | ||
tox-env: | ||
default: 'test' | ||
type: string | ||
description: 'Tox environment to run' | ||
checkout_ref: | ||
default: '' | ||
type: string | ||
description: 'Git ref to checkout' | ||
workflow_call: | ||
inputs: | ||
os-variant: | ||
default: 'ubuntu-24.04' | ||
type: string | ||
python-version: | ||
type: string | ||
tox-env: | ||
default: 'test' | ||
type: string | ||
checkout_ref: | ||
default: '' | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also include a scicat backend version input in the workflow_dispatch and workflow_call? so that when we trigger the workflow we can trigger the workflow with specific version, e.g, v4.8.0 or latest or stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
Do we need to make more changes to make it callable from the backend project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than above comment I have not spotted any major things. I think we can start with this workflow and see how it works together. I will add a workflow for this on scicat backend next week as I have quite a few tickets on hand at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it. You should be able to trigger the workflow now. Let me know how it goes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do, thanks!
9e1fef0
to
c9c3072
Compare
This should help us set up integration tests that get started by upstream projects (e.g., the backend).