Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auth error in from_token, from_credentials #51

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix auth error in from_token, from_credentials #51

merged 1 commit into from
Oct 11, 2023

Conversation

dylanmcreynolds
Copy link
Member

This fixes a bug where using from_credentials and from_token results in downstream auth errors because the Authorziation: Bearer token is not set.

@dylanmcreynolds dylanmcreynolds requested review from nitrosx and mkywall and removed request for nitrosx October 9, 2023 21:43
mkywall
mkywall approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mkywall mkywall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! this is the same solution I came to and the tests look good.

mkywall
mkywall approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mkywall mkywall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dylanmcreynolds dylanmcreynolds merged commit 8ff172b into SciCatProject:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkywall mkywall mkywall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanmcreynolds @mkywall