-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fixes for new backend #49
Multiple fixes for new backend #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on simplifying this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed the error handling here
Line 828 in f321072
f'Error retrieving token for user: {err["name"]}, {err["statusCode"]}: {err["message"]}' |
Line 851 in f321072
f' Failed log in: {err["name"]}, {err["statusCode"]}: {err["message"]}' |
Also, I noticed that Client._log_in_via_auth_msad
doesn't return anything, this is probably on me. Is this method still used by anyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch. I just pushed a commit for that.
I don't know if anyone uses that method, but the server supports the endpoint, so I think we have to leave it in.
Some small fixes for issues found testing against the new backend: